Lower casing reply to address in replies causes application issues

[matt@…]

Hello,

When replying to a message, RoundCube is setting the reply to address to lower case. I'm not sure the background or purpose for this, but it is causing replies to an internal application to fail.

What is happening:

• Application sends "new forum message" notification with a "reply to" address of "something-X12bFe2ffBBFAa@…"
• User should be able to reply to the message and post a reply to the thread
• RoundCube is lower casing the reply to address to "something-x12bfe2ffbbfaa@…"
• Application cannot determine which thread to post reply to because result of hash is no longer the same

IMHO, the lower casing is attempting to avoid an issue that should be handled at the MTA level (i.e. lower casing of e-mail addresses leading to undeliverable messages).

I'm not sure the best course of action, either take out the strtolower's or add a configuration option that lowercases the "reply to" if set?

I've fixed the issue by changing the following lines in program/steps/mail/compose.inc:

271:

from: $a_recipients[] = strtolower($addrmailto?);

to: $a_recipients[] = $addrmailto?;

280:

from: $a_recipients[] = strtolower($addrmailto?);

to: $a_recipients[] = $addrmailto?;

427:

from: $mailto = mb_strtolower(rcube_idn_to_utf8($addr_partmailto?));

to: $mailto = rcube_idn_to_utf8($addr_partmailto?);

462:

from: $part = strtolower($attribpart?);

to: $part = $attrib['part];

I'm not sure if it's overkill the remove all of the strtolower calls there, but it seems to be working okay from my limited testing.

Thoughts?

[alec]

I think we should keep lowercasing only for domain part of the email address.

[matt@…]

Works for me; I'm not aware of any MTA that has issues with case sensitivity of the domain parts.

[alec]

Fixed in 6ab9369eb194e4dde0cc830a84466dd240e95b23