Opened 10 months ago

Closed 10 months ago

#1488571 closed Bugs (fixed)

@include_once issue in Net/SMTP.php makes DigestMD5/CramMD5 unavailable

Reported by: bobleponge Owned by: alec
Priority: 5 Milestone: 0.8-stable
Component: SMTP connection Version: 0.8-rc
Severity: normal Keywords:
Cc:

Description

Hi,

The line 192 of Net/SMTP.php contains a check for strict equality of @include_once result against BOOL(true).

Since var_dump((@include_once 'somephp')) gives int(1), for an existing file and bool(false) for a non existing file in php, the line:

if ((@include_once 'Auth/SASL.php') === true) {

is wrong.
Either it should be:(disturbing)

if ((@include_once 'Auth/SASL.php') !== false) {

or simply:

if ((@include_once 'Auth/SASL.php')) {

If you don't do this, the advanced SMTP authentication methods are not available (this is a bug).

Change History (2)

comment:1 Changed 10 months ago by alec

  • Milestone changed from later to 0.8-stable
  • Owner set to alec

It is fixed in version 1.6.1. I'll update the package tomorrow.

comment:2 Changed 10 months ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [114cf128]

Note: See TracTickets for help on using tickets.