Error Message 'no connection'

[rosali]

Every time when the site gets unloaded while it is still waiting for an response of an AJAX request the GUI throws an error 'no connection'. May be you didn't notice it because the default AJAX request run quite fast. But it is really annoying if you have longer running AJAX requests like the calendar plugin does f.e. for checking reminders.

This happens for me with Chrome.

[rosali]

app.js

handle HTTP request errors
this.http_error = function(request, status, err, lock, action)

status is always 'error'. It is never 'abort'.

[thomasb]

I can confirm that issue. As you correctly found out, one cannot distinguish connection errors from aborts. So removing that handler would mean that we cannot detect and display real connection errors.

[rosali]

Nethertheless, I would remove it. It it really confusing for an end user to see these error messages.

[alec]

I think we could try the method with beforeunload handler from here ​http://stackoverflow.com/questions/1370322/jquery-ajax-fires-error-callback-on-window-unload

[klonos]

I'm getting this error with trunk 20120624. Subscribing in order to know when it'll be resolved.

[alec]

Please, confirm that attached patch fixes the issue.

[rosali]

Confirmed - works for me - Thanks, great!

[klonos]

Yep, fixed! Thanx ;)

[alec]

The "no connection" error message was added in ​https://github.com/roundcube/roundcubemail/commit/a9c1b877889aea93214a3635be6e652ba74e9f05. The decission to remove this case or to apply the patch is in Thomas's hands.

[thomasb]

Patch applied in commit 7794ae1387.