Opened 14 months ago
Closed 14 months ago
#1488446 closed Bug Patches (fixed)
r6073 breaks attachment naming
| Reported by: | sthen | Owned by: | |
|---|---|---|---|
| Priority: | 3 | Milestone: | 0.9-beta |
| Component: | Core functionality | Version: | git-master |
| Severity: | normal | Keywords: | |
| Cc: |
Description
diff:/trunk/roundcubemail/program/steps/mail/get.inc@6072//trunk/roundcubemail/program/steps/mail/get.inc@6073 modifies the code which chooses an attachment filename.
In the old code a proper filename was used if provided, otherwise a filename was synthesized from subject/second part of mimetype.
Now the second part of mimetype is *always* appended, e.g. "foo.doc.msword".
Possible fix in diff below.
*EDIT* Had to mangle the diff, s/MXSS/MESS/, stupid trac spam blocker.
Index: program/steps/mail/get.inc
===================================================================
--- program/steps/mail/get.inc (revision 6099)
+++ program/steps/mail/get.inc (working copy)
@@ -152,10 +152,9 @@
}
else {
$filename = ($MXSSAGE->subject ? $MXSSAGE->subject : 'roundcube');
+ $filename .= '.' . ($mimetype == 'text/plain' ? 'txt' : $ctype_secondary);
}
- $ext = '.' . ($mimetype == 'text/plain' ? 'txt' : $ctype_secondary);
- $filename .= $ext;
$filename = preg_replace('[\r\n]', '', $filename);
if ($browser->ie && $browser->ver < 7)
Change History (1)
comment:1 Changed 14 months ago by alec
- Milestone changed from later to 0.9-beta
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.

Fixed in [b4f95a93].