attachment lost problem

[neglau]

When I sent multiple attachments in the same time, if two or more finished the upload in the exact same time, only one attachment is add to mail.
I think it's a concurrency probleme of the session var.
There is not return info of the problem and the list still contain all the attachments

[alec]

Session race-condition would happen and it would be hard to get rid of them. However, we could return number of attachments in session on every upload request response. If the number is different than number of list rows we could send additional (verification) request and remove these which have disapeared from session.

[DmDS]

same problem... fix it please!

[alec]

#1488554 marked as duplicate of this issue.

[alec]

In race-condition case the attachment isn't really removed but only attachment info is removed from the session. We could keep attachment info in browser and try to fix session when message is sent/saved.

[thomasb]

Maybe we should consider using array_merge_recursive() in rcube_session::_fixvars().

[thomasb]

I found a solution to reduce race conditions when uploading attachments synchronously. See commit [f0a7159c]. Please test with latest checkout from git master.

[thomasb]

Was anybody able to test the latest git master version? I'd like to get some feedback before backporting the changes to the 0.9 release branch.

[alec]

It's hard to confirm the fix, because it's hard to confirm the issue by itself. With many tries I wasn't able to reproduce the issue again. I however found another case of it. I wasn't able to save the draft (and send) the message after: 1. upload many files, 2. while next bigger file uploading process is pending remove some of already uploaded files. It looks that after this some attachments already removed are still referenced in the session. This however is not 100% reproducible case, because hitting session race-condition is not simple.

[thomasb]

Fixed in release-0.9 branch with commits [d6cbdea0..bd723e56].