Opened 15 months ago

Closed 4 months ago

#1488381 closed Bugs (fixed)

Search in contacts on compose page

Reported by: alec Owned by:
Priority: 5 Milestone: 0.9-rc
Component: Addressbook Version: 0.8.0
Severity: normal Keywords:
Cc:

Description

The list of contacts in compose screen isn't really useful if there's no search feature.

Attachments (2)

search1.png (10.1 KB) - added by alec 4 months ago.
search2.png (8.3 KB) - added by alec 4 months ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 15 months ago by thomasb

The autocompletion is the search feature here. It's meant to be a listing in addition to the already existing autocompletion.

comment:2 follow-up: Changed 15 months ago by alec

You're saying we don't need searching here? Where's the point in having the list here then?

comment:3 follow-up: Changed 15 months ago by vanmeeuwen

I think a search is useful - perhaps another type of search than is used in other places - starting to type would just filter out the results from the list of contacts displayed that would not match.

comment:4 Changed 15 months ago by vanmeeuwen

FWIW, http://webmail.klab.cc/~vanmeeuwen/roundcubemail-trunk.svn/roundcubemail/, in the compose screen, with the third party 'compose_addressbook' plugin enabled, the icon just above the 'Cancel' button shows something similar to what we would want, I suppose.

comment:5 in reply to: ↑ 2 Changed 15 months ago by thomasb

Replying to alec:

You're saying we don't need searching here? Where's the point in having the list here then?

The point of having the list is to literally see a list of (possible) recipients. Let's say I wanna invite some friends to a party so I need to go through a list of addresses to pick the right persons without forgetting anyone. As opposed to writing a message to a specific person (which is perfectly possible with autocompletion) the list is there for "browsing". I don't say that searching isn't necessary at all here but I'd not consider it a showstopper.

comment:6 in reply to: ↑ 3 Changed 15 months ago by thomasb

Replying to vanmeeuwen:

I think a search is useful - perhaps another type of search than is used in other places - starting to type would just filter out the results from the list of contacts displayed that would not match.

Filtering a large LDAP directory with 600K entries? Good luck!

comment:7 Changed 15 months ago by alec

This should work the same as search in addressbook. We could even add identical searchbox above the list.

comment:8 Changed 15 months ago by thomasb

Yes, I definitely vote for that.

comment:9 Changed 4 months ago by thomasb

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from 0.7.1 to 0.8.0

Added search box in commit [bd0daee7fd8d].

comment:10 follow-up: Changed 4 months ago by alec

  • Resolution fixed deleted
  • Status changed from closed to reopened

Please, use splitter to change size of addressbook widget to see style issues with search box element.

comment:11 Changed 4 months ago by alec

Also, implemented search doesn't find groups, but maybe should.

comment:12 in reply to: ↑ 10 Changed 4 months ago by thomasb

Replying to alec:

Please, use splitter to change size of addressbook widget to see style issues with search box element.

What browser? Works for me.

Changed 4 months ago by alec

Changed 4 months ago by alec

comment:13 Changed 4 months ago by alec

Firefox 18.0.1 (see screenshots), the same in Opera. There's no issue in Chrome indeed.

comment:14 Changed 4 months ago by thomasb

Scaling fixed in [bcbfe0ba457f6fce752] groups are a bit trickier to implement...

comment:15 follow-up: Changed 4 months ago by alec

In Larry skin there's no indication about which addressbook is selected.

comment:16 in reply to: ↑ 15 Changed 4 months ago by thomasb

Replying to alec:

In Larry skin there's no indication about which addressbook is selected.

That could be a side-effect of my recent changes to the address book listing using the new treelist.js widget. I'm looking into it.

comment:17 Changed 4 months ago by thomasb

  • Resolution set to fixed
  • Status changed from reopened to closed

Selection bug fixed in [4223b1e38ff38d7]

I'm closing this for now. If searching in groups is important, please create a new ticket.

Note: See TracTickets for help on using tickets.