Opened 16 months ago
Closed 16 months ago
#1488372 closed Bugs (fixed)
Incorrect HTML displayed when viewing email from Disqus commenting system
| Reported by: | thydzik | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.7.2 |
| Component: | User Interface | Version: | 0.7.1 |
| Severity: | normal | Keywords: | html, display, disqus |
| Cc: |
Description
Emails received from Disqus (disqus.com), notifying me I have a new comment on my blog do not appear correctly, here is the examples;
Example 1;
This is a screenshot of the correctly displayed HTML, I have display HTML off and have clicked the HTML link present in the text only email;
http://thydzik.com/example1.png
Example 2;
This is a screenshot of the same settings, with the text only version; you can see the HTML link;
http://thydzik.com/example2.png
Example 3;
This is with the show HTML setting enabled; You can see there is different formatting, the users comment is missing. What is interesting, if I save the page as html, and reopen it, I can see the comment.
http://thydzik.com/example3.png
I have tested the following same email is other clients including Horde, SquirrelMail? and Gmail and it worked as expected. In both a self hosted and hosting-company hosted RoundCube the above was experienced.
I also noticed a Invalid ticked was created experiencing similar things, and there was no resolution;
http://trac.roundcube.net/ticket/1488016
Let me know if I can provide any further information, I am including screenshots and HTML pages saves.
Attachments (5)
Change History (11)
Changed 16 months ago by thydzik
comment:1 follow-up: ↓ 2 Changed 16 months ago by alec
- Component changed from User Interface to MIME parsing
- Milestone changed from later to 0.7.2
Provide the message source, please.
comment:2 in reply to: ↑ 1 Changed 16 months ago by thydzik
Replying to alec:
Provide the message source, please.
I have uploaded the eml file of the message, also made it available here
http://thydzik.com/example.eml
comment:3 follow-up: ↓ 4 Changed 16 months ago by alec
After a short investigation I can say it's css conflict. When you open HTML attachment, none of Roundcube styles are loaded, but when you open it in message preview content.css and mail.css are loaded. The HTML from Disqus use the same IDs as Roundcube does, e.g. "message".
comment:4 in reply to: ↑ 3 Changed 16 months ago by thydzik
thanks for that, is this something that will be resolved in a future Roundcube release?
comment:5 Changed 16 months ago by alec
- Milestone changed from 0.7.2 to 0.8-beta
I don't know. There are a few possible solutions for this. 1. Always use iframe for message body (not good for performance). 2. Add rc_ prefix to all Roundcube IDs and classes. 3. Remove IDs and class names from the message body (and replace with style attributes). Both 2. and 3. doesn't look simple to implement.
comment:6 Changed 16 months ago by alec
- Component changed from MIME parsing to User Interface
- Milestone changed from 0.8-rc to 0.7.2
- Resolution set to fixed
- Status changed from new to closed
Fixed default skin in [6205a30c]. There was no issue in Larry skin. Backported to 0.7 in r5961/svn.

Example 1 screenshot