Larry issues

[alec]

1. jquery-ui popup's title bar could be thiner.
   
2. No title in contact photo upload popup.
   
3. Wrong position of "Check spelling" link in plain text mode. Maybe we could integrate language selector with Spell button in toolbar, then the link could be removed.
   
4. Sometimes folders list footer is broken (misplaced icons and quota text).
   
5. Folder selection highlights folder name, messages count of the folder, but also subfolders' counters.
   
6. Lack of "#mailboxlist li.recent" style.
   
7. No left border in flag and listoptions column on messages list.
   
8. "All headers" in message view could look better.
   
9. Menu popups doesn't disapear when clicking on an iframe.
   
10. 2px artefact at the bottom of Mark button.
    
11. Wrong text with checkboxes alignment, e.g. in search menu.

[alec]

12. different height of rows in two lists of Settings interface.

[thomasb]

Replying to alec:

1. jquery-ui popup's title bar could be thiner.
   

It was the designer's choice to make them this big. Consider it a style artefact.

2. No title in contact photo upload popup.
   

We don't yet have a good concept to load localized texts which can then be used within skin scripts. Working on it.

3. Wrong position of "Check spelling" link in plain text mode. Maybe we could integrate language selector with Spell button in toolbar, then the link could be removed.
   

The link location is hard-coded in googiespell script.

4. Sometimes folders list footer is broken (misplaced icons and quota text).
   

Sometimes? Reproducable?

8. "All headers" in message view could look better.
   

I tried to simulate a box pulled out of the headers box. Any concerete suggestions?

11. Wrong text with checkboxes alignment, e.g. in search menu.
12. different height of rows in two lists of Settings interface.

Works for me. Browser? Screenshots?

[alec]

Replying to thomasb:

The link location is hard-coded in googiespell script.

Maybe, but we can modify it.

4. Sometimes folders list footer is broken (misplaced icons and quota text).
   

Sometimes? Reproducable?

This is strange, see attachment taken in Chromium. After closing browser the issue disapear.

11. Wrong text with checkboxes alignment, e.g. in search menu.

The same in Firefox and Chromium.

12. different height of rows in two lists of Settings interface.

Firefox 10. The same issue in addressbook view. No problem in Chromium.

[thomasb]

Fixed 5. and 7. in [3c9e9033], 6. in [b6837c37]

[alec]

I've observed 4th issue in IE8 (looks the same like in Chromium, see attachment.

[alec]

5. doesn't look fixed in IE8 (subfolders' counters are being highlighted still).

[thomasb]

Fixed 9. and 5. for IE in [14a3f281]

I still can't reproduce 4., 10., 11. in Firefox 10 or Chrome (I don't have Chromium). Please debug and fix it right on the browser where you observe the issues.

[alec]

4. and 10. fixed in [af5995d4].

[alec]

The fix for 6. could be better. Maybe use different color or change the color of messages counter too.

[alec]

unified spellcheck button

[alec]

I attached a patch which implements one button (with language selector) for html and plain spellcheckers in default skin. It's almost complete. Please, implement something similiar for larry.

[alec]

13. searchfilter.decorated in Opera looks even worse than native select.
14. Wrong cursor on autocomplete list.

[alec]

15. Messages below the login box should be centered (most important for long texts)

[alec]

16. buttons in mail toolbar are aligned to right, in addressbook to left. Alignment should be consistent. Also searchbox position should be considered.

[alec]

17. editor_content.css file for html editor doesn't exist in Larry.

[alec]

18. No quota indicator in folders manager.

[alec]

13., 14., 17. and 18. are fixed.

[thomasb]

Replying to alec:

16. buttons in mail toolbar are aligned to right, in addressbook to left. Alignment should be consistent.

Toolbar buttons are located above the container box they actually affect. Right-aligning them in address book view would leave them over the detail box but they are related to the list.

Also searchbox position should be considered.

That's another topic. As already discussed on several lists and forums, this requires the entire header to be re-arranged. I forwarded the request to our designer and hopefully he'll come up with a suitable suggestion.

[alec]

Not fixed: 8., 12., 16.

[alec]

19. Opera 11.62: wrong display of message list rows (thread children only), when message subject is longer than cell width.

[alec]

20. It would be great to see "text-overflow: ellipsis" behaviour on some tables (e.g. identities list) instead of a horizontal splitter.

[thomasb]

Fixed 19. and 20. The splitter remains for consistency reasons.

[alec]

21. Scrollbar and form buttons in iframes are sometimes partially hidden by statusbar. It's because the iframe style uses "height: 96%". Only message preview pane is free of this issue.

[alec]

22. Height of quick-search box and filter selector is different. Would be better to use the same height.

[alec]

8th fixed in [76248c7b].

[alec]

23. Something's changed and markasjunk and archive plugin buttons use icons from default skin with larry.

[alec]

24. Message forward menu doesn't present default selection.

[thomasb]

Replying to alec:

23. Something's changed and markasjunk and archive plugin buttons use icons from default skin with larry.

Empty folders got lost in git. Now fixed.

[thomasb]

Replying to alec:

24. Message forward menu doesn't present default selection.

That selection was confusing. It was not clear what happens when clicking where and saving prefs from a menu doesn't make sense to me. If you really insist in having a user-pref for that, it should be added to the settings section.

[alec]

Replying to thomasb:

That selection was confusing. It was not clear what happens when clicking where and saving prefs from a menu doesn't make sense to me. If you really insist in having a user-pref for that, it should be added to the settings section.

I think it was quite good shortcut, but we can move this to Settings.

[thomasb]

22. fixed in commit [f8c9610f197b79ea2e0b3983ecffe4c145804d2e]

[alec]

Attachment list issue

[alec]

25. Attachment list issue, see larry_issue25.png attachment to this ticket.

[thomasb]

Replying to alec:

25. Attachment list issue, see larry_issue25.png attachment to this ticket.

Can you please attach or send me the message source? I need to be able to reproduce this somehow.

[thomasb]

21. fixed in [fcd3f571]
22. fixed in [8ce60246]. The proper solution would be to add a toggle to hide/show the attachments list.

I guess we're more or less done with these issues now.

[alec]

21 is not really fixed (see attachment), 12 too. There's also 16 (but it's not a show stopper and we can exclude it to another ticket).

[thomasb]

21. now fixed in [98d09600].
22. isn't an issue anymore now that toolbar and search box position changed

I can't reproduce 12 on any of my browsers :-(