Contact photo resizing doesn't work

[niorg]

When uploading contact photos in the address book this results in the following message in the developer console:

--

[16:56:38.929] POST ​http://webmail.domain.com/?_task=addressbook&_framed=1&_id=&_uploadid=1327420598896&_action=upload-photo [HTTP/1.0 500 Internal Server Error 2751ms]

--

Roundcube keeps displaying 'loading..' until the request eventually times out. No error message can be found in the roundcube logs or in the apache logfiles.

Only clue is an empty file in the roundcube temp directory:

-rw------- 1 webmail webmail 0 Jan 24 16:56 rcmImgConvertwXPEtF

• uploading images smaller than 160 pixels works fine.
• paths to convert and identify binaries are correct.
• Imagemagick is properly installed and works when tested with a simple script.

[alec]

Works for me. This requires configuration, did you set im_identify_path and im_convert_path? I leave this open, because I think we could do some autodetection.

[niorg]

Yes, these are set correctly.

$rcmail_config['im_identify_path'] = '/usr/local/imagick/bin/identify';
$rcmail_config['im_convert_path'] = '/usr/local/imagick/bin/convert';

[alec]

The commands are

/path/to/identify 2>/dev/null 'file.jpeg'
/path/to/convert 2>&1 -flatten -auto-orient -colorspace RGB -quality '75' -resize '160>' '/tmp/phpjgQxA2' 'jpeg':'file.jpeg'

Please, execute them and check the result. Is this image-type-dependent or not?

[niorg]

Hi,

Those are working fine. Running in the RC webroot as the RC user:

$ /usr/local/imagick/bin/identify 2>/dev/null '/tmp/Screen Shot 2011-11-11 at 5.01.38 PM.png'
Screen Shot 2011-11-11 at 5.01.38 PM.png PNG 1141x852 1141x852+0+0 8-bit DirectClass 279KB 0.000u 0:00.000
$ /usr/local/imagick/bin/convert 2>&1 -flatten -auto-orient -colorspace RGB -quality '75' -resize '160>' '/tmp/Screen Shot 2011-11-11 at 5.01.38 PM.png' 'jpeg':'Screen Shot 2011-11-11 at 5.01.38 PM.jpg'
$ file Screen\ Shot\ 2011-11-11\ at\ 5.01.38\ PM.jpg 
Screen Shot 2011-11-11 at 5.01.38 PM.jpg: JPEG image data, JFIF standard 1.01

[alec]

I think it is because of spaces in filename. Please, confirm with a file without spaces in name.

[alec]

Also, what is your Roundcube installation path, does it contain spaces?

[alec]

[a71a97fa] and [f5a7e12f] should fix this issue. Re-open if needed.

[qustodium]

This is still broken:

PHP Fatal error:  Call to a member function get() on a non-object in trunk/roundcubemail/program/include/rcube_image.php on line 78, referer: 

Both settings are correctly configured, and running convert manually with the two commands Alec indicated above on the files uploaded by RC into temp/ works fine:

$rcmail_config['im_identify_path'] = '/usr/bin/identify';
$rcmail_config['im_convert_path'] = '/usr/bin/conversion';

[alec]

Replying to qustodium:

This is still broken:

PHP Fatal error:  Call to a member function get() on a non-object in trunk/roundcubemail/program/include/rcube_image.php on line 78, referer: 

Fixed in [b1b808d2].