Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#1488264 closed Bugs (fixed)

Settings -> Folders -> check on null value missing

Reported by: neubauer Owned by:
Priority: 5 Milestone: 0.7.1
Component: Core functionality Version: 0.7
Severity: minor Keywords: folder do not exist
Cc:

Description

If folders do not exist, they'll produce:
Dec 19 10:02:15 machine roundcube: PHP Warning: Invalid argument supplied for foreach() in roundcubemail-0.7/program/steps/settings/folders.inc on line 296

Following patch avoids the message:

* roundcubemail-0.7-orig/program/steps/settings/folders.inc 2011-11-09 11:03:54.000000000 +0100
--- roundcubemail-0.7/program/steps/settings/folders.inc 2011-12-19 10:04:16.000000000 +0100
* function rcube_subscription_form($attrib
* 293,299
--- 293,301 ----

if (!$disabled && $foldervirtual? && $folderlevel? == 0 && !empty($namespace)) {

$fname = $folderid? . $delimiter;
foreach ($namespace as $ns) {

+ if (is_null($ns) ) continue;

foreach ($ns as $item) {

+ if (is_null($item) ) continue;

if ($item[0] === $fname) {

$disabled = true;
break 2;

Change History (2)

comment:1 Changed 17 months ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [34c2e346].

comment:2 Changed 17 months ago by alec

  • Milestone changed from 0.8-beta to 0.7.1
Note: See TracTickets for help on using tickets.