Infinite redirect on attachment preview

[agrath]

Client reported attachments not loading, verified in IE & Chrome.

Tested with debugging proxy
Found infinite requests to URL?_preload=1&....
Checked code, in program/steps/mail/get.inc

if (!empty($_GET_preload?)) {

$url = str_replace('&_preload=1', , $_SERVERREQUEST_URI?);
$message = rcube_label('loadingdata');

Because in my case, first querystring parameter is _preload, (unsure if this is always the case) str_replace doesn't match and redirection to same url

Fixed by changing replaces to this:

$url = str_replace('?&','?',str_replace('&&','&',str_replace

('_preload=1', , $_SERVERREQUEST_URI?)));

Causes:

url?_preload=1&nextparam=2 to become url?&nextparam=2 and then url?nextparam=2
and
url?param=1&_preload=1&param2=2 to become url?param=1&&param2=2 then url?param1=&param2=2

Verified faulty str_replace existed in trac trunk before adding this

[alec]

Fixed in [5510a527].