rcmail->url() will omit parameter if value equals zero (php's empty vicissitudes)

[cabeca]

Hi,

rcmail->url() will omit parameter if value equals zero. This is because php's empty() treats any value with 0 (zero) as true. There are cases when you want a url parameter with the value zero, for example when displaying contact photos:

​https://example.com/rc/?_task=addressbook&_source=0&_cid=7400&_action=photo

Without _source parameter (as will happen with the current code, when _source equals zero) the photo doesn't appear.

Below is a patch to solve this particular issue, but maybe a full scan of the roundcube code is needed to see if empty() is really the function one wants to use, or if ''=== makes more sense in certain cases.

Best Regards
Miguel Cabeça

[alec]

Fixed in [77406bb7].