Opened 2 years ago
Closed 21 months ago
#1487956 closed Feature Patches (fixed)
custom default filter name for managesieve plugin
| Reported by: | mrfree | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.7-beta |
| Component: | Plugins | Version: | 0.5.2 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
I think managesieve plugin should use a custom filter name for the default script instead of the actual 'roundcube' hard-coded name.
Here is my patch proposal (Warn: it requires at least php-5.2 because of the PATHINFO_FILENAME constant)
--- managesieve.php.orig 2011-06-15 10:51:21.000000000 +0200
+++ managesieve.php 2011-06-15 10:51:53.000000000 +0200
@@ -103,7 +103,7 @@
else {
// if script not exists build default script contents
$script_file = $this->rc->config->get('managesieve_default');
- $script_name = 'roundcube';
+ $script_name = pathinfo($script_file, PATHINFO_FILENAME);
if ($script_file && is_readable($script_file))
$content = file_get_contents($script_file);
Change History (2)
comment:1 Changed 2 years ago by alec
- Milestone changed from later to 0.6-beta
comment:2 Changed 21 months ago by alec
- Resolution set to fixed
- Status changed from new to closed
Implemented as a separate config option in r5187/svn.
Note: See
TracTickets for help on using
tickets.

The patch is wrong because managesieve_default can be empty, but the idea is ok.