bug found in rcube_contacts.php

[deltatech]

Imported vcards get destroyed by line 541 in includes/rcube_contacts.php

The line was $vcard->reset(); After removing this line, imports work perfectly.

With the line present as it is in revision 4751, the only vcard fields that come thru is the name and email address because the reset destroys the rest of the information.

I am running revision 4751

[deltatech]

a correction to my original comment. removing the line $vcard->reset(); fixes the import problem but causes a major problem when editing an existing record. This is probably why the reset was put there originally.

So instead the correct change would be to run the reset but only IF there is no vcard present in the save_data

if( empty($save_data['vcard']) )
    $vcard->reset();

Now both imports and edits work perfectly

[thomasb]

I don't know what you're talking about. rcube_vcard::reset() only resets fields that are overridden by Roundcube when saving but leaves all other fields untouched. Proprietary fields such as X-ABUID survive import - edit - export.