Opened 2 years ago
Closed 2 years ago
#1487863 closed Bugs (fixed)
function _convert_pre can cause hangs
| Reported by: | ldeviator | Owned by: | alec |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.6-beta |
| Component: | PHP backend | Version: | git-master |
| Severity: | normal | Keywords: | |
| Cc: |
Description
in program/lib/html2text.ph
/**
* Helper function for PRE body conversion.
*
* @param string HTML content
* @access private
*/
function _convert_pre(&$text)
{
while (preg_match('/<pre[^>]*>(.*)<\/pre>/ismU', $text, $matches)) {
$result = preg_replace($this->pre_search, $this->pre_replace, $matches[1]);
$text = preg_replace('/<pre[^>]*>.*<\/pre>/ismU', '<div><br>' . $result . '<br></div>', $text, 1);
}
}
can cause a hang when forwarding/replying to a message. The message is attached. The message can be successfully sent if the dollar sign ($) is removed from the $0.00 inside the message body when forwarding/replying, or this function is skipped i.e.
function _convert_pre(&$text)
{
return;
...
}
}
Attachments (2)
Change History (4)
Changed 2 years ago by ldeviator
Changed 2 years ago by alec
comment:1 Changed 2 years ago by alec
- Component changed from Core functionality to PHP backend
- Milestone changed from later to 0.6-beta
- Owner set to alec
Attached patch fixes the issue.
comment:2 Changed 2 years ago by alec
- Resolution set to fixed
- Status changed from new to closed
Applied in [d483cd78].
Note: See
TracTickets for help on using
tickets.

message from Amazon.com