New config option for custom watermark & favicon.ico

[brandond]

A recent change to trunk added a new config option for custom logo. It would be nice if there was a similar option for the watermark image. Having both of these made configurable would remove almost all of my local skin customizations, and let me go back to the stock files.

[alec]

Because watermark.html page is not handled by templates engine, we'll need an option to replace the whole page too.

[thomasb]

The watermark is more neutral than the logo itself. The reason why to make the logo easy configurable was to encourage ISPs to customize their webmail frontent. We get plenty of support requests from users who think that Roundcube is a free mail service like Gmail, Hotmail, etc. and the ask questions about their "Roundcube mail account".

[klonos]

This feature would be really helpful to have. Custom favicon too please.

[alec]

Sample plugin

[alec]

I attached a sample plugin which replaces watermark.html file location and logo image.

[klonos]

...coming from #1487816 that was marked as a duplicate of this one. Also changing the issue title for better findability and in order to make sure that there's an option for the favicon as well (else the other issue is not a real duplicate).

So we're talking about adding a $rcmail_config['skin_watermark'] & a $rcmail_config['skin_favicon'] options in main.inc.php. Right?

[ASeques]

Thanks to the great template system in roundcube, adding support for custom favicon is quite easy.

Change in the file links.html the line:

<link rel="shortcut icon" href="/images/favicon.ico"/>

Into:

<link rel="shortcut icon" href="/images/<roundcube:var name="config:skin_favicon" />"/>

And to enable the option, in main.inc.php you just have to add something like:

$rcmail_config['skin_favicon'] = 'favicon.png';

[klonos]

The problem with the code in the previous post is that it still requires to place the custom favicon.ico file inside the /skins/larry/images/ folder. This means that the default favicon.ico file that already exists in that folder needs to be replaced. This in turn means that with the next upgrade the custom favicon will be overwritten with the skin's default which defeats the whole purpose of the hack.

I realize that the code could be changed so that the href tag points to a different folder than the skin's /images (or the custom favicon file could be renamed to something other than the standard "favicon.ico"). That would preserve the custom favicon file through successive upgrades, but still means placing a custom file within the file structure of a skin provided with the core code.

Furthermore, I wasn't able to figure a way to place the custom favicon.ico file in a level higher than that of the skin's folder. That is where the actual issue lies.

...I'll give a try to the sample plugin posted previously by alec and report back soon.