Opened 2 years ago

Closed 2 years ago

#1487722 closed Bugs (fixed)

typo in addressbook\show.inc

Reported by: lacri Owned by:
Priority: 3 Milestone: 0.5.1
Component: Addressbook Version: git-master
Severity: normal Keywords: typo
Cc:

Description

i found a small typo bug
in addressbook\show.inc on line 150
in function rcmail_render_url

$prefix = preg_match('![htfps]+://!', $url) ? '' : 'http://';

replace with

$prefix = preg_match('![https]+://!', $url) ? '' : 'http://';

Change History (4)

comment:1 Changed 2 years ago by thomasb

  • Resolution set to invalid
  • Status changed from new to closed

You should get back to the regex books. This expression is not a typo but correctly matches http:, https:, ftp: and ftps: urls.

comment:2 Changed 2 years ago by alec

  • Milestone changed from later to 0.5.1
  • Resolution invalid deleted
  • Status changed from closed to reopened

It matches also "stttttttt". We could rewrite it for clarity.

comment:3 Changed 2 years ago by thomasb

Sure it also matches other combinations but it does the job for simple protocol testing.

comment:4 Changed 2 years ago by alec

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [f2e94665].

Note: See TracTickets for help on using tickets.