Logging in redirects to login form

[FlyveHest]

I am running a 0.5 stable alongside my (working) 0.4.2, and have found this bug. (Seems like a dupe of #1487679, but following his hints does not work for me)

I have taken a clean 0.5 config file, and edited to fit my setup, but when I try and log in to RC, I just get redirected to the loginpage with an URL like this

​https://website.tld/?_task=login

If I then remove ?_task=login from the URL, then I get to my inbox.

No output in the apache log, and nothing seems out of the ordinary in the RC debug log.

I am running PHP v5.3.3 on a HTTPS site (selfsigned), let me know if any further input is needed.

[Kristoffer]

I have the same problem, ?_task=login gets added to the URL.
But it only happens if I enter the login page with a GET parameter.

​https://website.tld/ ---> Login OK!

​https://website.tld/?hii=1 ---> Login successful, but login screen is showed again!

[BenV]

Running php 5.2.17 on HTTPS with a real certificate gives me the same problem, tested in both Opera 11.01 and Firefox 3.6.13

The only logging I found is the userlogs that show the user logging in, no errors anywhere.

[thomasb]

Confirmed. This was introduced with [c3be8ed6]. Obviously parse_str() doesn't *add* parameters to the 2nd argument but entirely replaces it and thus _task => mail is gone.

[thomasb]

Fixed in [88007cf0] with the attached patch

[FlyveHest]

I have an interesting addition, I did a complete reinstall, wiped the directory, installed fresh, and now it works perfectly.

Same DB backend, though, didn't change that (other that what I did through my initial 0.4.2 -> 0.5 upgrade)

So, I think that maybe upgrading by overwriting folders leaves something behind that breaks RC (I have a backup of my 0.4.2 install, and will try and do an upgrade pr. the instructions later)

[michauko]

I had the same problem right after a 0.4.2 => 0.5.2 upgrade
I re-read the UPGRADING guide.
I'd say: if "don't forget to copy ./index.php as well" could be written in the guide......

:)

Replying to FlyveHest:

I have an interesting addition, I did a complete reinstall, wiped the directory, installed fresh, and now it works perfectly.

Same DB backend, though, didn't change that (other that what I did through my initial 0.4.2 -> 0.5 upgrade)

So, I think that maybe upgrading by overwriting folders leaves something behind that breaks RC (I have a backup of my 0.4.2 install, and will try and do an upgrade pr. the instructions later)

[mstarks01]

I can confirm what michauko reported in that the bug also exists in the documentation for 0.5.3. UPGRADING does not mention that index.php needs to be copied over.

[alec]

Replying to mstarks01:

UPGRADING does not mention that index.php needs to be copied over.

This is not true. ​http://trac.roundcube.net/browser/branches/release-0.5/UPGRADING