Opened 2 years ago
Closed 2 years ago
#1487664 closed Bug Patches (fixed)
dont_override setting does not override existing user preferences
| Reported by: | rveety | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.6-beta |
| Component: | Core functionality | Version: | 0.5-beta |
| Severity: | normal | Keywords: | config dont_override user preferences |
| Cc: |
Description
If I change my main config and set an option as dont_override, I would expect all of my users to experience the new setting. If a user had previously modified and saved that preference then they will not use the new value specified in the config file. For example:
Login as a user and enable preview pane, save the setting
Edit main.inc.php and specify preview_pane = false and dont_override = array('preview_pane')
Login as the user again, preview pane is still enabled
It seems set_user_prefs merges all saved user preferences without checking if they should override the main config. I wrote a small patch that seems to work for me. With the patch all dont_override settings are enforced even if a user previously modified the setting.
Attachments (1)
Change History (3)
Changed 2 years ago by rveety
comment:1 Changed 2 years ago by alec
- Milestone changed from later to 0.5-stable
comment:2 Changed 2 years ago by alec
- Resolution set to fixed
- Status changed from new to closed
Fixed in [bfb7d6e6].