dont_override setting does not override existing user preferences
|Reported by:||rveety||Owned by:|
|Severity:||normal||Keywords:||config dont_override user preferences|
If I change my main config and set an option as dont_override, I would expect all of my users to experience the new setting. If a user had previously modified and saved that preference then they will not use the new value specified in the config file. For example:
Login as a user and enable preview pane, save the setting
Edit main.inc.php and specify preview_pane = false and dont_override = array('preview_pane')
Login as the user again, preview pane is still enabled
It seems set_user_prefs merges all saved user preferences without checking if they should override the main config. I wrote a small patch that seems to work for me. With the patch all dont_override settings are enforced even if a user previously modified the setting.