Attachment preview window

[lingfude]

Add a config option to enable or disable the preview window when we click in an attachment so we can select between open or save the attachment.

[thomasb]

The preview only opens for file types that can be displayed in a browser (images, pdf, txt, html). You can always download it directly with right-click -> save file as

[lingfude]

I know that but some webmail users dont.
As the preview window has some problems with PDF files was important that there be this kind of configuration to whom have this kind of problem.

[lingfude]

This is so hard or complicated to do?
A variable in the configuration file and one condition in the file app.js on " open attachment in frame if it's of a supported mimetype" I think that is enough.

[alec]

Provide a patch.

[lingfude]

I do not know to program in PHP or Java but I've tried doing this condition.
The problem is that I do not know how to load the value of a variable from main.inc.php to app.js.
If you can help me with this maybe I can make the patch.

[lingfude]

I changed the 3 files attached to enable or disable the attachment preview window and it works.

main.inc.php (shearch for "enable or disable attachment preview window")
func.php (search for "set attachment preview window variable")
app.js (search for "if attachment preview window is enable")

If these changes are correct you can implement if you want.

[lingfude]

Patch to enable or disable attachment preview window.
It's the first time I made a patch hope it's ok.

[thomasb]

List of supported mimetypes is configurable since [f7b58afb].

You can set the config option to array() in order to not open the preview window at all.