Opened 2 years ago

Closed 2 years ago

#1487448 closed Feature Patches (wontfix)

Add keyboardInput class to password input field for compatibility with virtual keyboard.

Reported by: boum Owned by:
Priority: 5 Milestone: later
Component: Core functionality Version: 0.5-beta
Severity: normal Keywords:
Cc:

Description

We have a vkeyboard plugin almost ready to be released. It uses
greywyvern's javascript virtual keyboard (http://www.greywyvern.com/code/javascript/keyboard).

The single issue that prevents us from releasing it yet is: we currently need to patch upstream virtual keyboard javascript code to have it detect the password input field. The upstream javascript uses the "keyboardInput" class to detect it.

Please add this class to the password input field on the login screen, so that it can be detected without patching the javascript.

The attached patch implements this.

Attachments (1)

add_keyboardInput_class.diff (785 bytes) - added by boum 2 years ago.

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by boum

comment:1 Changed 2 years ago by rosali

Why not adding this class by javascript (jquery) by the plugin?

comment:2 follow-up: Changed 2 years ago by thomasb

...or in the template_object_loginform plugin hook. There you get the entire HTML code for the login form and you an easily add a class using string replacement functions.

comment:3 in reply to: ↑ 2 Changed 2 years ago by boum

Replying to thomasb:

...or in the template_object_loginform plugin hook. There you get the entire HTML code for the login form and you an easily add a class using string replacement functions.

Actually, this is what we did, we patched the vkeyboard javascript so that it attaches itself to the right form, but we'd prefer this to be implemented upstream in roundcube. That would ease the maintenance and upgrades, and we thought it might be a good killer feature for roundcube, hence the patch. Other ways, by template_object_loginform or by jquery sounds a bit hackish.

comment:4 Changed 2 years ago by alec

  • Resolution set to wontfix
  • Status changed from new to closed

Just create a plugin.

Note: See TracTickets for help on using tickets.