r4108: Problem with image attachments

[duelli]

Up to r4107, showing image attachments were correctly shown in the email preview and could be separately opened in a new window.

Since r4108, images are not shown inline anymore and can neither be opened in a separate window.

The error log shows the following message when I try to open an image attachment in a separate window:

[26-Oct-2010 15:24:02 +0200]: IMAP Error: LOGIN: [ALERT] Plaintext
 authentication is disabled, but your client sent password in 
plaintext anyway. If anyone was listening, the password was 
exposed. in /srv/roundcube-dev/program/include/rcube_imap.php on
 line 177 (GET /roundcube-dev/?_task=mail&_framed=1&_action=get&
_mbox=INBOX&_uid=20756&_part=2&_frame=1&_redirected=1)
[26-Oct-2010 15:24:02 +0200]: PHP Error: Unable to get/display 
message part. IMAP connection error in /srv/roundcube-dev/program
/steps/mail/get.inc on line 53 (GET /roundcube-dev/?_task=mail&
_framed=1&_action=get&_mbox=INBOX&_uid=20756&_part=2&_frame=1&
_redirected=1)

Maybe other attachment types are affected as well?!

As I said, it works with r4107 but not with r4108. Is any configuration change required?

[alec]

Please, enable imap_debug and attach the log.

[duelli]

Relevant imap debug log

[alec]

Please, check current trunk. Also with disabled all plugins. What do you have in default_host option?

[duelli]

I just checked with current [022bcd11], but the problem is still there.

$rcmail_config['default_host'] = 'ssl://myserver';

I found an interesting constraint. When I compose a mail with an image in Thunderbird and save it as a draft, the image is correctly shown inline as well as in a new window.

When I send the very same mail to myself, I get the described behavior of this bug!

Any ideas?

[alec]

This is strange. The log says that at some point it looses SSL flag stored in session and starts to cennect without SSL, but I have no idea what is the reason. Make sure you've overwritten all files properly while update.

[duelli]

Thank you very much for the effort. I just found a building block of the problem.

I have a plugin which uses the "authenticate" hook and modifies the default_host.

The plugin worked fine even beyond [854cf227] but for some reason the image loading broke. Without the plugin everything is fine!

Please, close this ticket as invalid. However something might have changed in [854cf227] that messes with "authenticate" hook?!

[alec]

Strange. "authenticate" hook is called only on log in.