Opened 3 years ago

Closed 3 years ago

#1487019 closed Feature Requests (fixed)

Add caching support in rcube_imap::get_uid/get_id methods

Reported by: alec Owned by:
Priority: 5 Milestone: 0.5-beta
Component: Core functionality Version: git-master
Severity: normal Keywords:
Cc:

Description

These methods are using only FETCH command or internal map. When we'd use DB cache also, e.g. in 'show' action 4 FETCHes will be raplaced with 4 SELECTs.

Attachments (1)

1487019.patch (1.8 KB) - added by neek 3 years ago.
Patch using message_cache_index

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by alec

  • Type changed from Bugs to Feature Requests

comment:2 Changed 3 years ago by neek

Proposal patch attached. The db cache consists in a hash uid => id per mailbox. Let me know if this is what you were looking for.

comment:3 Changed 3 years ago by alec

I was thinking about to use message table, which contains idx and uid. Using it will be much better.

Changed 3 years ago by neek

Patch using message_cache_index

comment:4 Changed 3 years ago by neek

Hi Alec,

Take a look at this new patch when you have some minutes. It now uses get_message_cache_index that makes any uid/idx lookup to hit icache array.

Thanks,
Adolfo.

comment:5 Changed 3 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

There maybe a situation when internal cache is not set. In this case fetching the whole index array is not good. I've improved this a little bit in [29983c16].

Note: See TracTickets for help on using tickets.