Opened 3 years ago

Closed 3 years ago

#1486958 closed Feature Patches (fixed)

Add phpdoc to properties

Reported by: vminakov Owned by:
Priority: 9 Milestone: 0.5-beta
Component: Core functionality Version: git-master
Severity: minor Keywords:
Cc: vova@…

Description

Modern IDEs are able parse @phpdoc comments to allow smart code completition. This is very useful and helpful feature, especially when developing plugins for Roundcube, which provides large API.

Roundcube lacks proper phpdoc comments for properties. For example, following @phpdoc comment in rcmail class would trigger code completition for rcube_template, if developers type rcmail::get_instance()->output-> in their plugins:

<?php
/**
 * Stores template.
 *
 * @var rcmail_template
 */
 public $output;
...

The same applies to methods: they return instances of rcube_user or rcube_template, however @phpdocs for these methods say they're returning just "object".

Attachments (1)

phpdoc_update.patch (92.5 KB) - added by vminakov 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by alec

We're open for patches.

comment:2 Changed 3 years ago by vminakov

  • Type changed from Feature Requests to Feature Patches
  • Version changed from 0.4-stable to svn-trunk

First patch attached. Affected files:

program/include/main.inc
program/include/rcmail.php
program/include/rcube_contacts.php
program/include/rcube_html_page.php
program/include/rcube_json_output.php
program/include/rcube_message.php
program/include/rcube_plugin.php
program/include/rcube_plugin_api.php
program/include/rcube_user.php

I'll keep working on other files.

comment:3 Changed 3 years ago by alec

  • Milestone changed from later to 0.5-beta

Changed 3 years ago by vminakov

comment:4 Changed 3 years ago by vminakov

Updated the patch. Based on [cb3dfdfe].

Updated files:
program/include/html.php
program/include/rcube_addressbook.php
program/include/rcube_config.php
program/include/rcube_imap.php
program/include/rcube_mdb2.php

comment:5 Changed 3 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Applied in [5c461bad].

Note: See TracTickets for help on using tickets.