Opened 3 years ago
Closed 3 years ago
#1486944 closed Bugs (fixed)
Inserting empty link when composing
| Reported by: | conigs | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.5-beta |
| Component: | User Interface | Version: | 0.4-stable |
| Severity: | normal | Keywords: | editor, composer, link |
| Cc: |
Description
If a link is inserted through the WYSIWYG editor, and no link url is given, a link to the hosted roundcube folder is used (e.g. http://yourdomain.com/mail) instead of an empty link or a warning that no url has been entered.
I feel there are two possible resolutions:
1.) Disable the "Insert" button until a url is provided.
2.) Warn the user that the link is empty and allow them to keep it empty (for whatever reason) or fix it.
But under no circumstances should a link be inserted that the user did not actually enter. This has bitten me a couple times when a link failed to be pasted in the link url field, was sent off, and the recipient wondered why they were being asked for a username and password after being sent to my roundcube installation. My fault for not checking, but an empty link would have been less embarrassing.
Change History (4)
comment:1 Changed 3 years ago by alec
- Milestone changed from later to 0.4.1
comment:2 Changed 3 years ago by alec
comment:3 Changed 3 years ago by alec
The same with relative_urls:true, but this one will probably require some changes in sendmail.inc.
comment:4 Changed 3 years ago by alec
- Resolution set to fixed
- Status changed from new to closed
Fixed in [e0a5ce02].
Setting convert_urls:false in TinyMCE.init() (program/js/editor.js) prevents from inserting "empty" links. I'm not sure that this setting desn't break something else.