Opened 3 years ago

Closed 3 years ago

#1486934 closed Feature Patches (fixed)

inline_images does not show all images

Reported by: roundreport Owned by:
Priority: 5 Milestone: 0.4.1
Component: Core functionality Version: git-master
Severity: normal Keywords:
Cc: wavexx@…

Description

The 'inline_images' parameter checks if an attachment is of mime-type 'image/*' to see if it's an image that can be displayed, but this check is not enough to display all images.

Many email clients use 'application/octet-stream' (mostly) to attach images. Any attachment generated by roundcube itself is of type 'application/octet-stream'.

It would be nice if the filename itself would be checked for an image extension (at least the most common ones).

See the attached patch which implements this functionality.

Thanks

Attachments (1)

inline_images.diff​ (598 bytes) - added by roundreport 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by roundreport

comment:1 Changed 3 years ago by roundreport

  • Cc wavexx@… added

comment:2 Changed 3 years ago by alec

  • Milestone changed from later to 0.4.1

comment:3 Changed 3 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [47d06e46].

Note: See TracTickets for help on using tickets.