TinyMCE: break blockquote with Enter

[roentgen]

Trying to reply to a HTML mail using HTML (hence TinyMCE).

Press Enter after a line of text in order to write your reply beneath it but the the new line is not inserted correctly, it is also half quoted.

Tested in Opera 9.7, Chrome x.x and Firefox.

[roentgen]

Screenshot

[alec]

Please, use 0.4-stable. Describe steps to reproduce more precissely. Works for me.

[roentgen]

I use the latest svn (small site, no serious problems so far, thanks for that).

After more testing it seems to work as intended when replying to HTML email written in roundcube (reply1.png)

However it misbehaves when replying to a mail written in Thunderbird (html-reply.png)

I'm not a coder so my best help would be to provide test cases ;)

[alec]

I didn't understand you at first. Now I see what you mean. Pressing enter doesn't break quoting, you must use TinyMCE's button (Blockquote) to do this.

[roentgen]

I don't mean that. I actually posted that as a feature request which was closed.

I tested some more replying to the simplest HTML message I could write in Thunderbird.

The results are better described in the attached images (html-reply-firefox.png and html-reply-opera.png)

[alec]

I don't realy understand what you mean. Step to make this work. Reply to a message, click inside a quoted text, click Enter, click Blockquote button in TinyMCE. What feature request are you talking about?

[roentgen]

I've tried to separate two related issues into two tickets. It seems to have caused more confusion than clarity - sorry about that.

​http://trac.roundcube.net/ticket/1486923 is a feature request but please let's forget about it for a moment.

The issue here is the actual bug report, not related to blockquote at all.

Let's take the attached screenshot for the firefox case (html-reply-firefox.png). I receive a HTML email written in Thunderbird. I press Enter *after* the first line in the original email. The following happens: the cursor jumps at the *beginning* of the second line. Enter should insert a totally blank new line.

In Opera, after pressing Enter after the first line the cursor jumps at the beginning of the signature (that is - one Enter press and the cursor jumps 4 lines!).

Maybe these issues are more like tinymce bugs and harder for you to fix and if so... let it be. (I really don't know which browser tinymce supports 'cause it doesn't work half decent in any of them)

[alec]

But this IS related to blockquote (citation). I'm unable to reproduce a problem in Opera. Probably this relies on content (HTML code) inside the blockquote. As I said in #1486923, editor will not gues what you want to do when you press Enter.

[roentgen]

It relies indeed. As I said take the simplest HTML email written in Thunderbird (v3 linux) and reply to it.

[raja]

I think it all concern about the HTML editor which it taking enter as a paragraph closing and starting i.e any text in paragraph will leaves some space before starting so I think instead of paragraph ending i think taking <br> break when we press enter will fixes this problem in RICH TEXT editor.....

[alec]

It looks you're right. Thunderbird uses BR tags.

force_br_newlines: true,                                   
force_p_newlines : false,
forced_root_block : '',

These TinyMCE's options make that editor uses BR instead of P, but... With this enabled it's not possible to insert a text in the middle of citation block. I think this issue is even worse. So, we need an other fix.

[alec]

There are many reasons to not use BR in html editor. Attached file (blockquote.patch) fixes this issue, but this is not final solution. Maybe this should be rewritten as a TinyMCE's plugin, also adding a switch icon in tinyMCE's toolbar to enable/disable this feature would be usefull. With this patch Enter key will break blockquote.

[alec]

I'm closing this ticket. This is very hard to implement properly in TinyMCE and current behaviour is not so bad in current version.