Roundcube should attempt to create Sent/Draft/Trash folders when it needs them

[markedwards]

I have a user that lost several weeks of sent mail because his Sent folder was not in the proper location (I think it got moved in another mail client accidentally). Most modern mail clients that I have used will attempt to create a special folder if it doesn't exist when its needed.

I suggest Roundcube needs this functionality. Mail should never evaporate if there is any way to avoid it. I would be willing to take a crack at creating a patch for this if it will help.

Thanks.

[alec]

Actually draft/sent folders are created if they are configured and aren't exists.

[markedwards]

I was under the impression that this only occurs on first login. It certainly isn't happening otherwise on my installation. I'm talking about this occurring any time these folders are needed. If they don't exist, the should be created.

[alec]

This occurs also when message is sended/saved, See sendmail.inc ca. line 590.

[markedwards]

Huh, I searched up several places in the forums claiming this only happens on first login. Folders are certainly not being created when messages are saved in my installation. I'll see if I can trace the source of the issue.

[alec]

Check you have default folders configured in Settings->Preferences->Special Folders.

[markedwards]

Special Folders are configured in main.inc.php:

$rcmail_configdefault_imap_folders? = array('INBOX', 'Drafts', 'Sent Messages', 'Junk', 'Deleted Messages');

and this is reflected in Settings->Preferences->Special Folders.

Create default folder is set to true in main.inc.php:

$rcmail_configcreate_default_folders? = true;

Mail is correctly being saved in the Sent Messages folder. If I then rename Sent Messages to something else outside of Roundcube, fire Roundcube up, and send a message, a new Sent Messages folder is never created and Roundcube sends the message without saving a copy of it or issuing any warning.

[alec]

Probably because in this situation you've got an other folder selected in compose form.

[alec]

Sorry, I mean, you've got "don't save" position selected in compose form.

[markedwards]

So what you're saying is that, in fact, Roundcube does not create the Sent folder when it needs it, it recognizes that the selected Sent folder is missing and puts "don't save" in the little menu.

What I'm saying is that, if a default folder is designated and "create_default_folders" is true, Roundcube should create that folder if it is missing when it needs to save to it.

[alec]

So, maybe we should add a check also in compose.inc.

[markedwards]

I think this is what I'm getting at. It seems to me that the behavior should be:

create_default_folders = true

---

Create default folders whenever they are needed, such as when opening a compose window and populating the "Save message in" menu, or when saving a Draft, or what have you.

create_default_folders = false

---

Folders should not ever be created, and the user should be given some kind of warning that a message will not be saved.

The only case where I see these rules are not being followed is in the Compose window example we have here, so perhaps it just comes down to this single case. But I haven't tested all cases, so maybe there are others.

Thanks! I'm happy to come up with a patch if that helps.

[alec]

Patches are always welcome.

[markedwards]

Proposed patch to fix issue

[markedwards]

This may not be the most elegant place for this (I don't know the code very well) but this solves the issue on my installation. I adapted code from sendmail.inc which you pointed to.

[markedwards]

Should I do anything else on this? Do I need to submit that patch anywhere else? The fix seems to work well for me.

[thomasb]

Fixed in [90e7080d]