Opened 3 years ago
Closed 3 years ago
#1486682 closed Feature Patches (fixed)
Implement full support for contact groups in address book plugins
| Reported by: | brandond | Owned by: | |
|---|---|---|---|
| Priority: | 2 | Milestone: | 0.4-stable |
| Component: | Addressbook | Version: | 0.4-beta |
| Severity: | major | Keywords: | contactgroup addressbook |
| Cc: |
Description
The current code does not support contact groups in address book plugins or LDAP - only the default SQL address book. It would be nice if full contact group support was enabled.
I am attaching a patch that adds full contact group support. It was originally developed on r3561, but applies cleanly against at least r3569. I have tested it on a production system using both the default SQL address book and an in-house read-only address book plugin. I have not tested it with LDAP.
The current version does not allow mixing of contacts from one address book source into a group from a different source. You must copy the contact into the other address book, and then add it to the group. This could be automated, but I am OK with how it works for now.
It also changes how some of the javascript plugin hooks work - instead of being called with values (group id, name, etc) they are passed an object with id, source, and name attributes.
I would appreciate this being merged ASAP, as it's a bit large to maintain out of tree for too long. Please let me know if there are any changes that I could make to speed acceptance.
Attachments (1)
Change History (5)
Changed 3 years ago by brandond
comment:1 Changed 3 years ago by toddtrann
Tested OK for me - that is, no errors. However, it did not work with LDAP groups. I know you didn't claim it would, I was just wishing. :)
If this brings us closer to generic groups, including LDAP, I'm in favor.
Todd
comment:2 Changed 3 years ago by brandond
Thanks for the feedback Todd. This patch was mostly to the addressbook core - I wanted to keep the SQL groups working, while allowing it to work at all for plugins and LDAP.
Additional work will have to be done to the LDAP backend to enable groups. There are a few different ways that people set up groups or lists in LDAP, so it will need to be pretty flexible.
comment:3 Changed 3 years ago by toddtrann
When you combine this patch with the patch from ticket #1486377 then you have full drag and drop copying between address books working: database to LDAP, and also reverse. Works great, all fields were copied over, even those added in that other ticket.
Todd
comment:4 Changed 3 years ago by alec
- Resolution set to fixed
- Status changed from new to closed
Applied in [bb8012cf].
patch to provide complete contact groups implementation