Opened 3 years ago
Closed 3 years ago
#1486606 closed Feature Patches (fixed)
small patch to fix contact group js
| Reported by: | JohnDoh | Owned by: | thomasb |
|---|---|---|---|
| Priority: | 5 | Milestone: | 0.4-beta |
| Component: | Addressbook | Version: | git-master |
| Severity: | normal | Keywords: | |
| Cc: |
Description
I know the contact groups are being worked on so apologies if these are known issues and I am being impatient. I noticed a couple of little quirks and tweaked the JS to solve them
Attached is a small patch, it makes 3 changes in the JS for contact groups:
1) really overwrite the source id when selecting groups - at the moment if you have another address book selected the id is not set back to 0 as it should be
2) do not allow switching of groups while renaming - the call back function uses this.env.group as the id of the group to be renamed, if the client has changed groups between pressing rename and [Eneter] the wrong one is renamed
3) add updategroup client side event - there are events for insert and remove, having one for update would also be useful
Attachments (1)
Change History (3)
Changed 3 years ago by JohnDoh
comment:1 Changed 3 years ago by alec
- Milestone changed from later to 0.4-beta
- Owner set to thomasb
comment:2 Changed 3 years ago by thomasb
- Resolution set to fixed
- Status changed from new to closed
Applied in [f4f4522b]