Patch to remove leading wildcard search in auto-complete

[serpico7456]

Here is a simple patch to prevent auto-complete from doing leading wildcard searches. eg a search for 'ran' only returns RANdy and RANdall, not bRANdi, bertRANd or bRANdenburg. It is my opinion that that RC will be an improved and more intuitive product if it implements the functionality that people are used to. This will mimic the results of most email clients like, mail.app, thunderbird, gmail, outlook, et al.

There are two patches, one for the SQL address book, and one for LDAP. SQL patch courtesy of skaero

[serpico7456]

patch for SQL address books

[serpico7456]

patch for LDAP address books

[serpico7456]

For this to make sense you would have to be searching firstname and surname fields in auto-complete as well, or the surname will be ignored since it only does trailing wildcard.

--- autocomplete.inc.orig	2010-03-19 10:43:40.850998671 -0500
+++ autocomplete.inc	2010-03-19 10:44:02.109309629 -0500
@@ -28,7 +28,7 @@
   foreach ($book_types as $id) {
     $abook = $RCMAIL->get_address_book($id);
     $abook->set_pagesize($MAXNUM);
-    if ($result = $abook->search(array('email','name'), $search)) {
+    if ($result = $abook->search(array('email','name', 'firstname','surname'), $search)) {
       while ($sql_arr = $result->iterate()) {
           $contacts[] = format_email_recipient($sql_arr['email'], $sql_arr['name']);
 	  if (count($contacts) >= $MAXNUM)

[alec]

-1 from me.

[thomasb]

What most email clients do is searching by word. In order to improve this feature in the way you suggest we should create a fulltext index and search this (without the leading wildcards). Unfortunately not all database backends support this.

[alec]

As you see in patches, there's no need for fulltext searching. This feature if implementend should be optional.

[alec]

#1486956 marked as a duplicate of this request.

[alec]

I'd like to see a patch that merges this solution with #1487907 and a user-configurable preference for this behaviour.

[alec]

Implemented in [f21a04c0].