blocked.gif should be removed when replying to a message

[rosali]

It is a problem to send a link to blocked.gif when Roundcube runs in a http authentication protected location.

For further details: ​http://www.roundcubeforum.net/5-release-support/17-pending-issues/6301-blocked-images-link-blocked-gif-being-insetred-into-sent-emails.html

[alec]

Would be better to attach it to the message automatically.

[alec]

blocked.gif file attaching

[alec]

Patch attached, what do you think?

[rosali]

The patch looks fine to me! But you should consider to user Content-Id (cid) URLs to embed images. This feature was requested for images in html signatures as well and it would be very useful, IMO.

[alec]

But did you test this patch? blocked.gif will be embeded on send.

[rosali]

I could test the patch today evening ...

[rosali]

I've tested the patch. Basically it works great!

I have encountered one problem. If the line with the cid url is wrapped,
then blocked.gif is not displayed by Outlook (Express). So I think you have
to make sure that the cid url is located in a single line.

<div class=3D"postcardBarText"><img src=3D"cid:31113baba3c2c8f2c35baff75aca=
6603@…" alt=3D"" /></div>





--=_6b5b6abf00fa1d5918f06fecf5768f51
Content-Transfer-Encoding: base64
Content-ID: <31113baba3c2c8f2c35baff75aca6603@…>
Content-Type: image/gif; name=blocked.gif
Content-Disposition: inline; filename=blocked.gif

R0lGODlhZAAyAIAAAPrOzgAAACH5BAAAAAAALAAAAABkADIAAAJNhI+py+0Po5y02ouz3rz7D4bi
SJbmiabqyrbuC8fyTNf2jef6zvf+DwwKh8Si8YhMKpfMpvMJjUqn1Kr1is1qt9yu9wsOi8fksvls
KwAAOw==
--=_6b5b6abf00fa1d5918f06fecf5768f51--

[alec]

Patch applied in [b575fa90].