Opened 3 years ago

Closed 3 years ago

#1486467 closed Bugs (fixed)

Inconsistency when not using default table names

Reported by: vidarberg81 Owned by: alec
Priority: 10 - Lowest Milestone: 0.4-beta
Component: Database Version: 0.3.1
Severity: trivial Keywords:
Cc:

Description

RoundCube Version 0.3.1-20091031

In file program/include/rcube_user.php:

Line 388:
if ($user_id = $dbh->insert_id('users'))

Suggested fix:
if ($user_id = $dbh->insert_id(get_table_name('users')))

Change History (3)

comment:1 Changed 3 years ago by alec

  • Milestone changed from later to 0.4-beta

No, see get_sequence_name() in main.inc. We cannot use it like this. But... we should get rid of db_sequence_* config options and use hardcoded standard sequence names as <table_name>_id_seq. This will be consistent and will prevent from problems like described in this request.

comment:2 Changed 3 years ago by alec

  • Owner set to alec

comment:3 Changed 3 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

This will require a lot of work, so currently I've applied a simple fix in [e1ac2173].

Note: See TracTickets for help on using tickets.