autocomplete shows entries without email

[grigora]

the address autocomplete feature shows any entry from the addressbook, also those without an email address.
as we are going to write an email i suppose this is annoying and moreover, as the list is limited, it draws useful space from valid email addresses.

see the attached patch

[thomasb]

Hmm, the address book should prevent you from saving records without e-mail address.

[grigora]

you are right. but in my case the ab is an ldap directory that serves also other applications (for phone numbers, street addresses etc...)

[alec]

It would be better to extend LDAP searching filter string, to not fetch these entries at all.

[grigora]

i have tried setting the filter to "email=*" in config and it works like a charm.
the drawback (speaking as an ldap admin) is that someone will add a new entry instead of just adding the email attribute to the existing one, because he won't see it in rc ab. resulting in a duplicate.

[grigora]

nevermind, i have solved by setting the address book read-only.

[toddtrann]

Although at first I agreed with Thomas, I can see that perhaps address book entries would have a blank email field for many strange reasons that we can't dream up (maybe the sysadmin migrated from an old system and imported the contacts direct to SQL?)

However your patch only addresses one of the conditions; there are two:

• adding a single user with blank email address
• adding group that contains a user with blank email address

I'll upload a patch that handles both. Although I see that the group totals do not agree with the number of users added to the autocomplete field, I think this is actually better than adding that user with blank address.

Todd

[alec]

Fixed in [25fdec59].