bug in function abbreviate_string

[white]

The function abbreviate_string in program\include\rcube_shared.inc does not work correctly.

It should replace the middle part of a string with "..." if it is longer than the allowed length.

The function does not shorten the string in the exact middle
and the function makes the string two characters longer than the allowed length!

The algorithm would only work if the place holder for the removed part is only one character. I suggest to change the function into something like this (untested!):

function abbreviate_string($str, $maxlength, $place_holder='...')
{
  $length = mb_strlen($str);
  
  if ($length > $maxlength)
  {
    $place_holder_length = mb_strlen($place_holder);
    $first_part_length = floor(($maxlength - $place_holder_length) / 2);
    $second_starting_location = $length - $maxlength + $first_part_length + $place_holder_length;
    $str = mb_substr($str, 0, $first_part_length) . $place_holder . mb_substr($str, $second_starting_location);
  }

  return $str;
}

Changing this function will effect several things. It will for example effect the display of the folder list.

[alec]

Fixed in [cea5bc82].