Ticket #1486377 (new Patches)

Opened 9 months ago

Last modified 4 months ago

extended addressbook patch

Reported by: bbeveridge Owned by:
Priority: 5 Milestone: 0.6-beta
Component: Addressbook Version: svn-trunk
Severity: normal Keywords: addressbook, extended
Cc: osos@…, nysander@…, matt@…

Description

Hi All, Here is a patch to extend the current addressbook, it adds commonly used extra fields such as: work_number home_number fax_number mobile_number title company work_address home_address note

it has been applied against revision 3183 it also has vcard import and export with these extra fields according to the vcard standard.

Currently it only has en_US labels It also includes the modifications to all the initial and updates for SQL.

Attachments

extended_addressbook1.diff (16.2 KB) - added by bbeveridge 9 months ago.
extended_addressbook patch
extended_addressbook_fromv4.diff (16.4 KB) - added by toddtrann 4 months ago.
extended_addressbook_r3593.patch (16.6 KB) - added by toddtrann 4 months ago.
extended_addressbook_0.4stable.patch (16.8 KB) - added by osos 9 days ago.
Updated patch to apply cleanly to 0.4 stable

Change History

Changed 9 months ago by bbeveridge

extended_addressbook patch

Changed 9 months ago by osos

  • cc osos@… added
  • milestone changed from later to 0.4-beta

Thank you.

Working great here. Exactly what I have been waiting for.

Changed 6 months ago by alec

  • milestone changed from 0.4-beta to 0.5-beta

Changed 4 months ago by osos

Seems not to apply smoothly to 0.4-beta!

Alec: Any changes this could be added to 0.4-stable ?

At least I think the "note"-field should be added, to be able to smoothly convert from Squirrelmail addressbook.

Changed 4 months ago by toddtrann

I went through the old patch, and applied all by hand to current svn trunk, and then made a new patch. Should now apply cleanly.

However, I did not test functionality, only updated patch.

Todd

Changed 4 months ago by toddtrann

Now test results:

[OK] Click on contact, enter data into new fields, save form, view data [OK] Click on contact again, change data, save, view data [OK] Export contact that does not contain new fields [Failed] Export contact with data in new fields (new data does not show up in vCard file??)

I could not test import, there were other errors not related to this patch.

Todd

Changed 4 months ago by toddtrann

Changed 4 months ago by toddtrann

And finally with respect to LDAP, this works. Once I put in all the correct LDAP field names into the config file, I can save and view all of the new fields.

When you combine this patch with the patch from ticket #1486682 then you have drag and drop copying between address books working: database to LDAP, and also reverse. Works great, all fields were copied over.

Todd

Changed 4 months ago by toddtrann

Changed 4 months ago by toddtrann

Sorry for multiple uploads, I checked out a fresh copy from svn and my previous patch would not apply, here's a better one against r3593.

Note that vCard export still isn't working for me, another set of eyes on it would be good, I can't see the problem.

Changed 4 months ago by nysander

  • cc nysander@… added

Changed 4 months ago by mattrude

  • cc matt@… added

This patch seems to be working well on r3615. I will be nice when it starts working with LDAP, but I'm sure that will happen soon.

Changed 4 months ago by toddtrann

Matt, it is working with LDAP for me. Did you test it and its not working for you? Note that you have to fill in the blanks for the LDAP fields where the new data is stored in main.inc.php since I didn't put any default ones. I didn't think they were standardized enough.

Changed 4 months ago by mattrude

Im sorry it is working, I just didn't fill in the config file. I am having a problem with the Fax field, but that may be my fault.

Here's my current config if this helps anyone.

{{

'name_field' => 'cn', 'email_field' => 'mail', 'surname_field' => 'sn', 'firstname_field' => 'givenName', 'work_number_field' => 'telephoneNumber', 'home_number_field' => 'homePhone', 'fax_number_field' => 'Fax', 'mobile_number_field' => 'mobile', 'title_field' => 'title', 'company_field' => 'o', 'work_address_field' => 'street', 'home_address_field' => 'homePostalAddress', 'note_field' => 'description',

}}

Changed 9 days ago by osos

Updated patch to apply cleanly to 0.4 stable

Note: See TracTickets for help on using tickets.