r3102 breaks plugin configuration defaulting

[brandond]

A number of plugins rely on being able to load a default set of configuration variables, and then overwriting those with a second set. This looks like:

$this->load_config('config/config.inc.php.dist');
if(file_exists("./plugins/forward_as_attachment/config/config.inc.php"))
  $this->load_config('config/config.inc.php');

The 'forward as attachment' plugin is one public plugin that does this, and we have several other in-house plugins that rely on this behavior as well. r3102 broke this behavior by not allowing load_config to overwrite existing properties when called by a plugin.

This is, to us, a major regression.

[rosali]

@brandond:

I have fixed my plugins meanwhile to work with SVN3102++

if(file_exists("./plugins/forward_as_attachment/config/config.inc.php"))

$this->load_config('config/config.inc.php');

else

$this->load_config('config/config.inc.php.dist');

[thomasb]

The changes in [3597cc2c] were made because plugin configs could override user settings. Maybe we need make a major change in the way how user settings are merged over the config properties.

[thomasb]

Fixed in [b545d3e8]. Each set of configuration parameters overwrites existing values but user prefs will always be merged over all of them.