message_compose plugin hook doesn't set proper params

[pink]

Once message_compose plugin hook is executed, it doesn't set proper params using returned value.

It's caused by overwriting

$_SESSION['compose']['param'] = $plugin['param'];

by returned value.

Patch included

[alec]

I think you're not right. Array_merge() is not needed here.

[pink]

It's not needed as long as plugin developer will carry about merging it in plugin, check such plugin:

class reply_params extends rcube_plugin
{
  public $task = 'mail';

  function init()
  {
    $this->add_hook('message_compose', array($this, 'addcc'));
  }

  function addcc($args)
  {
    $params = array(
        'param'       => array(),
        'attachments' => array(),
    );

    if (isset($args['param']['reply_uid']))
    {
        $h = rcmail::get_instance()->imap->get_headers($args['param']['reply_uid'], NULL, true, true);

        if (false !== strpos($h->to,'groupmail@address.com'))
        {
            $params['param']['cc']  = 'groupmail@address.com';
        }
    }

    return $params;
  }
}

It will set only CC, but other params, like body, to, subject are erased. I think you should have more mercy for plugin developers and don't oblige them to inspect sources.

I'm re-opening this bug, because of above explanation. If you still think it's not a problem please close it.

[alec]

Patch applied in [ceeab9ed].