Opened 4 years ago

Closed 4 years ago

#1486301 closed Bugs (fixed)

rcmail_get_skins finds other dot-directories that it shouldn't

Reported by: horsepunchkid Owned by:
Priority: 5 Milestone: 0.4-beta
Component: Core functionality Version: 0.3.1
Severity: minor Keywords:
Cc:

Description

You've thoughtfully filtered out ., .., and .svn, but I happen to use bzr. You could keep the !in_array test, or you could just swap that out for a !preg_match against anything beginning with a '.' instead.

Attachments (1)

roundcube_0.3_no_dot_skins.patch​ (525 bytes) - added by horsepunchkid 4 years ago.
Patch to filter out all dot-directories from the skin list

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by horsepunchkid

Patch to filter out all dot-directories from the skin list

comment:1 Changed 4 years ago by alec

  • Milestone changed from later to 0.4-beta

comment:2 Changed 4 years ago by duelli

I would like to propose a more general mechanism I would like to see.

It would be useful if you can "mark" folders (e.g. old out-dated backups of your own skin templates) which still are in the skins/ folder as unusable, so a user cannot choose them in its settings.

Something like this

mv myskin myskin.backup

comment:3 Changed 4 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [90b1cb2e]. If you want to hide some directories just rename them using dot as first character.

Note: See TracTickets for help on using tickets.