Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1486255 closed Bugs (invalid)

Global (or host) configuration and user preferences merge

Reported by: cchantep Owned by:
Priority: 7 Milestone: later
Component: Core functionality Version: 0.3-stable
Severity: minor Keywords: config preferences
Cc:

Description

Using latest 0.3-stable version, which I find great, I have some trouble with mbox names set in config/main.inc . As roundcube account auto creation is enabled, when a new user login, he have some empty values in his preferences, e.g. trash_mbox = . The trouble is that when those preferences are merged with global configuration, these empty values overide proper value from global configuration, and so for exemple such auto created account cannot find its removed messages in the trash, as trash folder is (same thing for sent folder).

I've codec a quick patch, which is not meant to be the best as I'm not an expert of roundcube code. This patch remove empty values from user preferences before merge with global configuration, so problem describe before was avoided. Maybe a it should only do it for some config/pref value (such as folder name), maybe it's account auto-creation code that should avoid adding such empty preferences.

Attachments (1)

rcmail-prefs_merge.patch (444 bytes) - added by cchantep 4 years ago.
Quick patch (2009-10-30)

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by cchantep

Quick patch (2009-10-30)

comment:1 Changed 4 years ago by alec

  • Resolution set to invalid
  • Status changed from new to closed

This looks to me as config issue. A new user when is created has no preferences, so global values are used. Works for me at least with current svn-trunk.

comment:2 Changed 4 years ago by cchantep

Maybe it's fixed in svn-trunk, but I confirm that the behaviour you describe so that when "new user when is created has no preferences, so global values are used", is not the one with 0.3-stable I've downloaded just this week.

comment:3 Changed 4 years ago by cchantep

Reading trunk code at SVN, I don't see change in rcmail.php or rcube_config.php that could have fixed the describe trouble. Maybe at user preferences init ?

Note: See TracTickets for help on using tickets.