#1486155 closed Bugs (fixed)
[Patch] Login edit fields for username/password are the wrong width on some platforms
| Reported by: | sikkerhedorg | Owned by: | |
|---|---|---|---|
| Priority: | 2 | Milestone: | 0.3.1 |
| Component: | User Interface | Version: | 0.3-stable |
| Severity: | minor | Keywords: | |
| Cc: |
Description
We have been using RoundCube in our company for several years now. We are very satisfied with it, and we recently upgraded to version 0.3-stable without problems.
However, one bug has persistently annoyed us. On some combinations of browser and os, the edit fields in the login page are too wide. In fact, they extend quite a bit beyond the width of the "frame" (div) that contains them.
I've wondered why this was the case, although I didn't find a solution before I upgraded to 0.3-stable. It seems that the fields are hardcoded to have the attribute [size="30"]. This is, in my opinion, not good practice, and certainly something that conflicts with both the goals and implementations of CSS.
In other words, it seems wrong. I have attached a patch that removes this attribute.
On my platforms (Firefox and Konqueror on Linux), the login fields now look perfect. Is there any reason (that I'm not aware of) for keeping the size attribute?
I hope my patch can be merged. Thank you.
Attachments (1)
Change History (4)
Changed 4 years ago by sikkerhedorg
comment:1 Changed 4 years ago by alec
- Milestone set to 0.3.1
Works for me. What laguage are you using? BTW, I've made possible to set size in template ([6a486e0b]).
comment:2 Changed 4 years ago by netbit
- Resolution set to fixed
- Status changed from new to closed
Alec, I've done small changes ([df2a51e3]) to complement your change.
The attribute "size" may vary according to browser and OS combination. Since the "size" attribute is just a visual design attribute, it's recommended to use CSS instead.
comment:3 Changed 4 years ago by sikkerhedorg
Excellent. I'm very happy that my changes are useful :)
patch against 0.3-stable to fix edit fields