Ticket #1486150 (closed Bugs: fixed)

Opened 6 months ago

Last modified 5 months ago

[PHP 5.3 compatibility] Installer: don't use dl() calls on SAPI

Reported by: jaspersl Owned by:
Priority: 5 Milestone: 0.3.1
Component: Installer Version: 0.3-stable
Severity: minor Keywords: PHP 5.3
Cc:

Description

On Mac OS X 10.6 (ships with PHP 5.3) and Windows (PHP 5.3) using dl() gives: Fatal error: Call to undefined function dl() when using Apache 2.2 SAPI module.

The notes on http://nl2.php.net/dl usuage are pretty obvious but as @dl() is used, the installer (installer/check.php) aborts without a fancy warning.

In my opion Roundcube should not attempt to use dl() at all to load modules unless it's on CGI.

Suggested fix:

$msg = PHP_SAPI != 'cli' @dl($_ext) ? 'Could be loaded. Please add in php.ini' : ;

Change History

follow-up: ↓ 4   Changed 6 months ago by jaspersl

Sorry for the copy/paste code. The double single quotes and OR were stripped off.

$msg = PHP_SAPI != 'cli' || @dl($_ext) ? 'Could be loaded. Please add in php.ini' : '';

  Changed 6 months ago by alec

  • milestone changed from later to 0.3.1

  Changed 6 months ago by alec

  • status changed from new to closed
  • resolution set to fixed

Fixed in r2977.

in reply to: ↑ 1   Changed 5 months ago by info@…

Replying to jaspersl:

Sorry for the copy/paste code. The double single quotes and OR were stripped off. {{{

$msg = PHP_SAPI != 'cli' @dl($_ext) ? 'Could be loaded. Please add in php.ini' : ; }}}

Note: See TracTickets for help on using tickets.