Opened 4 years ago

Closed 2 years ago

#1486120 closed Bugs (fixed)

Display of "Today" label ignores date formatting.

Reported by: jasonb Owned by:
Priority: 5 Milestone: 0.6-beta
Component: User Interface Version: 0.3-stable
Severity: minor Keywords:
Cc: jasonb@…

Description

This is a minor nit, but I've set my date strings to look this this:

$rcmail_configdate_short? = 'l, g:i a';
$rcmail_configdate_long? = 'n/j/y, g:i a';

This has the effect of putting a comma after the day or date before displaying the time. For example:

Thursday, 2:37 pm
9/2/09, 9:27 am

However, when an email is dated "today" the comma is not displayed:

Today 4:35 pm

Why is "Today" ignoring the comma formatting character that I've specified in the my date strings?

When I was using 0.3RC I "fixed" this by editing program/localization/en_GB/labels.inc (or US for the other localization) and using:

$labelstoday? = 'Today,';

This forced the label to be "Today," rather than "Today" - so I hard-coded the comma in. But I shouldn't have to do that. (This also doesn't survive upgrades, because the labels.inc file is overwritten. So, when I upgraded to the final version of 0.3 I had to edit this again.)

Change History (2)

comment:1 Changed 3 years ago by alec

Maybe we should get rid of "Today" and display only time for todays timestamps, as Thunderbird2 does?

comment:2 Changed 2 years ago by alec

  • Milestone changed from later to 0.6-beta
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [c5dedd79].

Note: See TracTickets for help on using tickets.