Opened 4 years ago
Last modified 13 months ago
#1486097 new Feature Requests
Remove "Add contact" link on contacts already in address book
| Reported by: | djib | Owned by: | |
|---|---|---|---|
| Priority: | 5 | Milestone: | later |
| Component: | User Interface | Version: | git-master |
| Severity: | minor | Keywords: | |
| Cc: | dkg@… |
Description
I suggest removing the "Add contact" link/icon when a user is already in the address book.
I enclose a patch for revision 2929.
Attachments (1)
Change History (9)
Changed 4 years ago by djib
comment:1 Changed 4 years ago by alec
- Milestone set to later
comment:2 Changed 4 years ago by alec
- Milestone changed from later to 0.3.1
Verified. We need also multicolumn index on user_id, email, del columns.
comment:3 Changed 4 years ago by thomasb
- Severity changed from normal to minor
Well, of a user clicks the icon and address is already saved in the address book, an according messages appears. Due to performance reasons we should stick with that. Checking all addresses might slow down the message display.
comment:4 Changed 4 years ago by alec
- Milestone changed from 0.3.1 to later
This feature could be also extended to display link to addressbook info for known senders, but I agree with Thomas, for performance reasons we should make this optional.
comment:5 Changed 4 years ago by alec
...and this should be extended to check all addresses with one SQL query.
comment:6 Changed 4 years ago by djib
I really like this feature because it allows me to quickly check if a friend is already in my address book. Does it really have that big an impact on performance?
comment:7 Changed 4 years ago by alec
It could have. If you have big addressbook, slow database or many addresses to check. Another solution is to sent checking ajax request after displaying a message.
comment:8 Changed 13 months ago by dkg
- Cc dkg@… added
Patch for revision 2929