Opened 4 years ago

Closed 4 years ago

#1485989 closed Bugs (fixed)

installer checks date.timezone for no reason

Reported by: Atropos Owned by: till
Priority: 2 Milestone: 0.3-stable
Component: Installer Version: git-master
Severity: normal Keywords: date.timezone installer
Cc:

Description

Changeset 2752 includes a patch to the installer that checks to see if date.timezone was set. This was an attempt to fix a problem with timestamps in RC logs not matching timezone of timestamps in Apache logs. ('Different Timezone offsets in my RoundCube log') did not mention any other reasons the patch may be needed. It did not fix the problem according to the person who experienced that issue. This patch does create a problem with users who want to install RC on web hosts who have a default installation of PHP that does not specify a timezone using date.timezone. I suggest backing out the patch.

Change History (9)

comment:1 Changed 4 years ago by alec

  • Milestone changed from later to 0.3-stable

Roland has been

comment:2 Changed 4 years ago by till

Roland has been ... ?

Btw, you could use .htaccess to set date.timezone, or you tell your webhost that they have a mis-configured PHP.

comment:3 Changed 4 years ago by till

  • Owner set to till

comment:4 follow-up: Changed 4 years ago by rosali

Till, it looked like the setting of the timezone in php fixed different timezone offsets between RC and apache logs. But since a few days the weird issue started again.

comment:5 in reply to: ↑ 4 Changed 4 years ago by Atropos

Replying to rosali:

Till, it looked like the setting of the timezone in php fixed different timezone offsets between RC and apache logs. But since a few days the weird issue started again.

Why not have the installer determine a "server timezone" offset from GMT and store that as a config variable, then patch write_log to apply this offset? That is how the user date functions work after all. Apparently rosali can't trust PHP to use the same timezone for the duration that Roundcube is executing, or perhaps in a mod_php/FastCGI environment PHP's timezone is changed.

comment:7 Changed 4 years ago by till

  • Priority changed from 5 to 2

Again, they should set it in .htaccess - instead of editing the installer. Regardless, they could also email their hosting company to fix this.

php_value date.timezone Europe/Berlin

[ Or whatever is applicable. ]

Re: your issue

I don't know enough about your environment. I'm pretty sure it's the same timezone issue as before. You can ping me via email and we'll try to resolve this.

comment:8 Changed 4 years ago by alec

Again. This shouldn't be required setting. We should move this to some "Recommended" section.

comment:9 Changed 4 years ago by alec

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [11e670da].

Note: See TracTickets for help on using tickets.