Opened 4 years ago

Closed 4 years ago

#1485977 closed Bugs (fixed)

SVN r2743: hook render_page

Reported by: rosali Owned by:
Priority: 5 Milestone: 0.3-stable
Component: Plugin API Version: git-master
Severity: normal Keywords:
Cc:

Description

The check to avoid endless loops by the callback function of 'render_page' is too restictive. We can't use output->send('[pluginname.]template') anymore. The check breaks my plugins and the hook can't be used to redirect to another template. Please change rcube_template.php as follows ...

rcube_template.php line 291:

if ($exit != 'recurse' && $this->app->plugins->is_processing('render_page')) {

I also suggest to modify the WIKI for the render_page hook accordingly:

If you want to use output->send() in the callback function of this hook, then call it by output->send('[pluginname.]template','recurse') and take care not to cause endless loops. Otherwise the output->send() will be skipped.

Change History (2)

comment:1 Changed 4 years ago by rosali

  • Component changed from Addressbook to Plugin API
  • Milestone changed from later to 0.3-stable
  • Version changed from 0.2.1 to svn-trunk

comment:2 Changed 4 years ago by thomasb

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [f78dab1c]. The keyword is now "recur"

Note: See TracTickets for help on using tickets.