Bug in svn2755

[lacri]

in the changeset 2755 (Use request tokens to protect POST requests from CSFR) are some bugs.

Identities can not be saved the error is operation not permittet.
and the error log says
Missing argument 2 for rcube_template::request_form(), called in /var/www/roundcube/program/steps/settings/func.inc
and i found an other bug in relation to this in /steps/settings/func.inc

the var $hidden does not exists the name is $add_hidden

if (is_array($hidden)) {
      $hiddenfields = new html_hiddenfield($hidden);
      $form_start .= $hiddenfields->show();
    }

[jensmartin]

This changeset is also causing problems for plugins.
For instance does the password plugin not work after this change.

The following error gets logged when clicking the settings icon:

[15-Jul-2009 15:17:06] PHP Warning:  Missing argument 2 for rcube_template::request_form(), 
called in /mail/program/steps/settings/func.inc on line 442 and defined in /mail/program/include/rcube_template.php on line 950

[thomasb]

Warnings fixed in [7477973d].

I don't see the problem your describing in /steps/settings/func.inc
The argument name is $hidden and not $add_hidden:
/browser/trunk/roundcubemail/program/steps/settings/func.inc#L433

[thomasb]

Correct link from previous comment is trunk/roundcubemail/program/steps/settings/func.inc#L433