Messages with 'Content-Disposition=inline' header set, get added to attachments when forwarding

[arr2036]

As per the title.

There's no reason for Mime parts with Content-Disposition inline to be attached to forwarded email, yet the code suggests they should be.

Just removing the $part->disposition=='inline' stops mail being attached. Does anyone know why this condition is there?

[alec]

They should be attached if you forward the message (with inline images) in html format.

[arr2036]

Ok this isn't HTML.

The full condition is:

if (($part->ctype_primary != 'message'

!$bodyIsHtml) &&

($part->disposition=='attachment'

$part->disposition=='inline'

$part->headerscontent-id?

(empty($part->disposition) && $part->filename)))

{

So you've already determined that it's not HTML. You can't have inline images in a text email.

[alec]

Fixed in [12217da8].