UUEncoded attachment are not read correctly

[jernst]

Here is an example mail that doesn't show up correctly in Roundcube.

[...] Date: Thu, 7 May 2009 16:32:14 +0200 From: X To: Y Subject: Facsimile received from 022123456 Message-Id: <20090507163149-0223642891.22818@voip>

Resolution: 204, 98 pixels/inch Page Number: 0-1 Fax Data: clean (0 = 0x0) Fax Receive Time: 5 secs Fax DCS: 00 55 1E

begin 644 20090507163149-0223642891.pdf M)5!$1BTQ+C$@"B7BX\_3"C$@,"!O8FH*/#P@"B]4>7!E("]#871A;&]G(`HO M4&%G97,@,RP(%(@"CX^"F5N9&]B:@HR(#@;V)J"CP\(`HO0W)E871I;VY$ M871E("A$.C(P,#DP-3W,38S,C$P*0HO36]D1&%T92H1#HR,#`Y,#4P-S$V M,S(Q,"D*+U!R;V1U8V5R("AL:6)T:69F("\@=&EF9C)P9&8@+2`R,#`V,#,R M,RO(&0I"B]#<F5A=&]R("AS<&%N9'-P*0H^/B*96YD;V)J"C,@,"!O8FH* M/#P@"B]4>7!E("]086=E<R*+TMI9',@6RT(#@4B!=(HO0V]U;G0@,2`* M/CX@"F5N9&]B:@HT(#`@;V)J"CP\"B]4>7!E("]086=E(`HO4&%R96YT(#,@ M,"!2(HO365D:6%";W@@6SN,#P,"P+CP,#@-C`Y+C@X,C,@,S(V+C(P M-#%=(HO0V]N=&5N=',@-2P(%(@"B]297-O=7)C97,@/#P@"B]83V)J96-T M(#P\"B]);3$@-RP(%(@/CX*+U!R;V-3970@6RO26UA9V5"(%T*/CX*/CX* M96YD;V)J"C4@,"!O8FH*/#P@"B],96YG=&@@-BP(%(@"B<sup>/@IS=')E86T* M<2@-CY+C@X,C,@,"XP,#P(#N,#P,"S,C8N,CT,2P+CP,#@,"XP M,#P(&-M("]);3$@1&\@40H*96YD<W1R96%M"F5N9&]B:@HV(#@;V)J"C8R M"F5N9&]B:@HW(#`@;V)J"CP\(`HO3&5N9W1H(#@@,"!2(`HO5'EP92`O6$]B M:F5C="`*+U-U8G1Y<&4@+TEM86=E(HO3F%M92O26TQ"B]7:61T:"`Q-S(X M"B](96EG:'0@-#0T"B]":71S4&5R0V]M<&]N96YT(#$*+T-O;&]R4W!A8V4@ M+T1E=FEC94=R87D@"B]&:6QT97(@+T-#25141F%X1&5C;V1E("]$96-O9&50 M87)M<R\/"O2RM,2O0V]L=6UN<RQ-S(X("]2;W=S(#0T-#X^"B</sup>/@IS M=')E86T*\[4"'8\5H*=BT3QH1H1H1(,D1\B@S0R1%OY$[*&4&5;-!"$9F%*B M)!D&1(B;F4:\SN56\JD%."A!A!H&"84(,$&$#-BA!A!A!A`P@\(/(P4$T#-B MDW614C8L[`[YDJLJYUB1$B1M9#ILHV.5<MPY&MHUM&QHUN=(:V2*5=&$\J\J MZ4J_/"'(CD>$!$/<CD>$.1'+.D1R,1'(\("(<(=!8\?U2"+']KN/I-I-[I-P M:3:0Z1U:CCI#]%PXN5S!F.+E<XN0GB5&+1>09@*@O"02,RR.-!82#$*UPE_V MOP?I>1QY07I?00;EW$CB\NXD<67>;0(9=Y%IPEX0000-V;82P@@@V1C\(+_9 M&/\G?I=FV(-<sup>E_ZPO6%K</sup>L,'D(#Q#P@@@@W3Q#""1L8<sup>$%_CEP3W-@GI=.&_ M2_:</sup>C9_1LE#R!9JM!(+O)Y!;I:";2;22%M)1;22[SS_2YV$$8KXAR)?B'\ MA\<sup>;"R($YP$1"V0N)BM$+@HX(<!$0N"F*/B,4?%8I2K!&*S00X"$W5`1(H!+ M"!@O#)O#</sup>&3?_P0?_X0,+PPF"\,(,)@@PH0858,+A>EQ$1$1$1$1$1$1$1$ M1$1$1$1$1$1$1$4AI1*]0->7,B?*U:PX76ZZ\%CB3A M"@0QA$%VWI@B5AA$@R*VQF$F&$@_TNW_W(73T@A_D4N#<sup>V5`3]G3*"</sup>V9 MUOG%3#$*#2D$;>A7"!G!@H1<0,*(B(\KZ`4@UX_<sup>6XP,'?Q6S*J$.T#) M5&S)4<K@J#-3DD0<A;-([-4$8*AP\KE(?Q701]`SF7'Z:1Y"0*+HQ&X]$C(</sup> M?%.,N1\80/(XSXS;+DD"1';9\9LR.(7(\,(&$1,([+<DY'9/I@9MG0LCCIHA M/)CD\(O(($7P@1?PX1L#89N"-;8*SD$:VPS<D$"=PCXPV>,W(<sup>6"#-YK889M MG(/AA-!'P.SEYL0:1401?-!I(+'2#<+'ZQX7I):%U"VQ\>J_;2"0U]+L4"T% M:7_GA?SPO^J4^GPS?S07_VZ_M)"DDE2"^_PCY_"/GV&R;DN?X,U\(^?_;2_A MI4L$$DJ1?,6VEZK</sup>J<sup>&&+9[_-I_5?_8V&<_B$'3$*JA</sup>&(2#";)#AL&$&$&R M0X:#"8,ASD6P:#"<4P80-DAPP@P@P@P@P@VC-AD<!A!Q$1$1Q$1$1$1$1$1$ M1$1$1$:$1'I2;"HRWH4:C^6]8,$5(T%,Q3,9.1.1H,S&3F4&:PAT&5R@Y7*Q M$?C8@C6&$?F$?F$?PC6&$:PPCX&$?T4]%/(;-((VU4K:W@@Z2TFT$V@FQ= M)M)L7%QQT$?0,\Z],5$IY)L<=!)-I-H)!>D"1';81$LCPDY/B%<FY'!9RW)> M1V#."G"+F7&;9P*<&;9<C461Q<sup>B&+</sup>DD"?<sup>"8)</sup>D$"=PS<:V&F""-83080:8 M9N"/C8((V!AI@@PF@C6$$?&PS<$?`[.72!%\Q]!()%0_]%0T5#_22\<,G.[; M:4+0O2#89.C2W0N%A(:[J@7Z"00AO_$-B&_]4LS%=O;32</[MTWSA_PJ22 M;2!($G;2;2=_8;)N2I"/D([MB$VCNTOOO".[;28A7_\&"2P01;20(T2!&B2 M;2;222\=5008:*3BF_;/>VD@@PV-%:,]PSG\00-B%AB$"()!!("#$(,0C MP0X$`P0,&0]`;)#AA-!R%H$T:-!A-D7@88A!-!M2%PBV&$S##(X#"#B(B(B M(B(B(B(BCG*V"I'.4U;2"2202LA-EB9"-7QH8_+<N(1AG3*R!$KE@PC9#7*X MW2-*"#IK$B?[K"#;$P:1(($&8AQ.#/#"!]AAH]T7&#1H1\88+PCXT?+!<,/5 M!GM01K@C(CH6V/PVDD@N@@B.:"KGJ-VT2:]*@DJ"15$O8,T8,*&DD$C"2""2 MQS_1='+;/9A/QA%R@RYR+2R$LBX'@@;(N"F#B(B*0B(B(C2ENMG'Y:!M2W3@ MY,P((YDM#DXSH,E@IH1.1H,IS.AFH9.949H9%B-!30B<I7!,&;P<KC=#HJB. MK0((_,(UAA&L,(V!HIX(PP!HIX5%/"-88181K#"-8<KE(=)L@_WQX(CR./ M03:3:3:38X00N.BAXY!Z3:";2;2;I[8(,UPXY'&8,P:6VEF8S`S;'2;2;V]$ M)YB`LT@EDV.DVDW32S@0,$3E]G(.'2VTL(UL,)I+1>!X)@O_2_DJ*]* M"-<>O_;2QVTD%_L->@V**AXI?@O_]!)*@@B.?_I;:69BMT@O\,5(;PEYU! M?T%_VD@DDJH)%"7_2V*PCY;2!)M)M(D6WOH0>0>VD"3:3:4-4"!8)%U1=8E% M_J>7M:JQH$:)M)M((+;2.26:11>VD@1HFTFTH@A!,G:#9"9!P@P@V2<-!I M&H5H$#9(<-H$03Q"#$(T8(&Q"S80$#\$#PQ"!$$\0@Q"B(B(B(B(.(B(C0B( M1VO6$DAB=Z%J/_ROH!2#7C_Y7"&59DF<.'#_Y73EGAGRSPS,LV,.$;(1K M81LA&MA&RCY"-;I..DXZ3MB/\\+YX7PS4_"/GPCY\&:SYL-!JK#0:JPT&1TZ MK#)#@F2'##)#@F2'##)#@HIDAPXB(B(B(B(*X0X?RNG+.#/CA&RCY"-; MI.V(_PS4_!FL;#09=.JPR0X**9(<.(B(*X0X?RNG+/#A&R$:W2<?YX7 MX1\V&@U6&2'!,D.'$1'*]8SXZ/D(UNV(\,U,&:SYE>I.JXIDAPXB/_ M5ZQGQT?(1K=L1X9J8,UGS*]2=5Q3)#AQ$?_<sup>5]*0:\8((IE;F1S=')E M86T*96YD;V)J"C@@,"!O8FH*,C$P,0IE;F1O8FH*>')E9@HP(#D@"CP,#P M,#P,#@-C4U,S4@9B*,#P,#P,#Q-BP,#P,"!N(HP,#P,#`P,#8X M(#P,#P(&X@"CP,#P,#R,3<@,#P,#@;B*,#P,#P,#(X,2P,#P M,"!N(HP,#P,#P-#4W(#P,#P(&X@"CP,#P,#U-S4@,#P,#@;B`* M,#P,#P,#4Y,RP,#P,"!N(HP,#P,#R.3,U(#P,#`P(&X@"G1R86EL M97(*/#P*+U-I>F4@.0HO4F]O="Q(#@4B*+TEN9F\@,BP(%(@"B])1%L\ M-C<T-3A"-D)#-C(S-T(S,C8Y.3@S0S8T-S,T.#,S-C8</sup>/#8W-#4X0C9"0S8R M,S=",S(V.3DX,T,V-#<S-#@S,S8V/ET*/CX*<W1A<G1X<F5F"C(Y-34*)25% #3T8* ` end

[alec]

Attach sample message, please.

[MKelma]

UUENCODED TEST MAIL

[Lazlo]

Tested mail, works in Thunderbird, but doesn't show up correctly in Roundcube. (Running on trunk)

[alec]

Fixed in r2471.

[MKelma]

thank you - working now. but it produces some error in log files: [13-May-2009 11:26:04] PHP Warning: convert_uudecode() [<a href='function.convert-uudecode'>function.convert-uudecode</a>]: The given parameter is not a valid uuencoded string in /..path../program/lib/imap.inc on line 2424

[alec]

Fixed in r2473.

[MKelma]

whoooa[[BR]] speed record.... thanks.
working now as expected.

[MKelma]

UUENCODED Testmail - attached word document -> NOT working !!

[MKelma]

above testmail with uuencoded word-file does not work in RC
works in thunderbird etc...

[alec]

Fixed in r2475.

[alec]

http://www.roundcubeforum.net/5-release-support/17-pending-issues/6435-error-received-attachment.html[[BR]] Inline attachments in plain text body of non-MIME message are not handled.

[alec]

Fixed in r3680.

[towa48]

Guys i have a spaces in uuencoded files (pdf)! Attached file visible in Thunderbird, but doesn't show up correctly in Roundcube (4.0 stable).

But I have blank page if I edit regexp (rcube_message.php) from

$uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n(([\x21-\x7E]{0,65}\n)+)`\nend/s';

to

$uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n(([\x20-\x7E]{0,65}\n)+)`\nend/s';

Looks like preg_match_all() get a error, but error log is empty. Help pls

Apache 2.2.9 PHP 5.2.6-1 Roundcube 4.0 stable

[alec]

Attach sample message.

[towa48]

sry, i cant. message contains personal data

...
Date: Thu, 12 Aug 2010 06:57:29 +0100
Message-ID: <xxx@intldn.manfinancial.net>
X-Mailer: Microsoft CDO for Windows 2000
Content-Class: urn:content-classes:message
Importance: normal
Priority: normal
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.2757
X-OriginalArrivalTime: 12 Aug 2010 05:57:30.0048 (UTC) FILETIME=[3FC5D400:01CB39E3]



begin 666 20100811CS60800730.pdf
M)5!$1BTQ+C,*):T*,2 P(&]B:@H\/ HO5'EP92 O0V%T86QO9PHO4&%G97,@
M,S0@,"!2"B]/=71L:6YE<R S-2 P(%(*+U!A9V5-;V1E("]5<V5/=71L:6YE
M<R *+U9I97=E<E!R969E<F5N8V5S(#(@,"!2"B]/<&5N06-T:6]N(%LP("]8
...
...
...
M138U-C@^70HO26YF;R R,2 P(%(*/CX*<W1A<G1X<F5F"C$X,38U,@HE)45/
"1@H`
`
end



If you are not an intended recipient of this e-mail, please notify the sender, delete it and do not read, act upon, print, disclose, copy, retain or redistribute it. http://xxx.com - for important additional terms relating to this e-mail.

[alec]

If've checked on wikipedia ;) Looks you're right about the change in regexp. Some implementations are using spaces. If you got a blank page there must an error message in the log.

[towa48]

I think this is PCRE limit http://www.pcre.org/pcre.txt

The  maximum length of a compiled pattern is 65539 (sic) bytes if PCRE is compiled with the default internal linkage size of 2.

I think I need other algorithm for big files.

[towa48]

Ok. My internal linkage size is 1 (8 KBytes) and preg_match_all() show a blank page. This is my alternative function

	function uu_decode(&$part)
	{
		// @TODO: messages may be huge, hadle body via file
		if (!isset($part->body))
		$part->body = $this->imap->get_message_part($this->uid, $part->mime_id, $part);

		$parts = array();
		/* UUDECODE MOD */
		$uu_regexp = '/begin [0-7]{3,4} ([^\n]+)\n/s';
		if (preg_match_all($uu_regexp, $part->body, $matches, PREG_SET_ORDER)) {
		
			// update message content-type
		$part->ctype_primary   = 'multipart';
		$part->ctype_secondary = 'mixed';
		$part->mimetype        = $part->ctype_primary . '/' . $part->ctype_secondary;
			
			$uu_endstring = "`\nend\n";
			
			// foreach attachments
			foreach ($matches as $pid => $att) {
				
				$startpos = strpos($part->body, $att[1]) + strlen($att[1]) + 1; // "\n"
				$endpos = strpos($part->body, $uu_endstring);
				$filebody = substr($part->body, $startpos, $endpos-$startpos);
				
				// remove attachments bodies from the message body
				$part->body = substr_replace($part->body, "", $startpos, $endpos+strlen($uu_endstring)-$startpos);
				
				$uupart = new rcube_message_part;
				
				$uupart->filename = trim($att[1]);
				$uupart->encoding = 'stream';
				$uupart->body     = convert_uudecode($filebody);
				$uupart->size     = strlen($uupart->body);
				$uupart->mime_id  = 'uu.' . $part->mime_id . '.' . $pid;
				
				$ctype = rc_mime_content_type($uupart->body, $uupart->filename, 'application/octet-stream', true);
				$uupart->mimetype = $ctype;
				list($uupart->ctype_primary, $uupart->ctype_secondary) = explode('/', $ctype);
				
				$parts[] = $uupart;
				unset($matches[$pid]);
			}
			
			// remove attachments headers from the message body
			$part->body = preg_replace($uu_regexp, '', $part->body);
		}
		/* END UUDECODE MOD */
		
        return $parts;
    }