Opened 4 years ago

Closed 2 years ago

#1485791 closed Feature Requests (fixed)

Firefox/IE7 don't ask to remember the password

Reported by: brunoqc Owned by:
Priority: 5 Milestone: 0.5-stable
Component: User Interface Version: 0.3.1
Severity: minor Keywords: firefox ie7 password
Cc: bruno@…

Description

It don't work with Firefox 3.1 beta 3 on Linux x86_64, with Firefox 3.0.7 on Windows XP and with Internet explorer 7.0.5730.11 on Windows XP. Both browsers don't ask to remember the password on login.

It work with the latest version of Konqueror from SVN.

Change History (12)

comment:1 Changed 4 years ago by lacri

Is not a bug is a Feature ;)

in skins/default/templates/login.html

<roundcube:object name="loginform" form="form" autocomplete="off" />

you can remove autocomplete="off" and the logindata will be fill automated when is save in your browser or passwort manager.

comment:2 Changed 4 years ago by alec

  • Milestone changed from later to 0.2.2

comment:3 Changed 4 years ago by alec

  • Resolution set to wontfix
  • Status changed from new to closed

comment:4 Changed 3 years ago by markedwards

  • Resolution wontfix deleted
  • Status changed from closed to reopened

How about an main.inc.php option to toggle this for username? I have users that log in via the same browser daily and they want their username remembered.

I don't want to encourage the password getting recorded, but I'm okay with the username. I also don't want to have to remember to patch the template every time I upgrade.

comment:5 Changed 3 years ago by markedwards

  • Type changed from Bugs to Feature Requests

comment:6 Changed 3 years ago by markedwards

  • Milestone changed from 0.2.2 to 0.4-beta
  • Version changed from 0.2.1 to 0.3.1

comment:7 Changed 3 years ago by alec

  • Milestone changed from 0.4-beta to later

I don't like to create options for such features. You can write a plugin which will remove autocomplete="off" from page.

comment:8 Changed 3 years ago by thomasb

  • Severity changed from normal to minor

...or use svn checkout to update your installation. This will keep your changes alive.

comment:9 Changed 3 years ago by markedwards

Thanks for the help. I coded up a simple plugin to remove only the autocomplete="off" from the username field. I will submit the plugin to the repository to aid any others who want to add this functionality.

comment:10 Changed 3 years ago by laurent

@markedwards: I'm very interested by your plugin.

Quick question, why is the autocompletion turned off by default and asking people to create a plugin if they want to change that instead of the other way round? (let people choose if they want their browser to remember their credentials or not and let paranoiac anti-freedom sysadmins ;-) who wants to forbid that create their plugin (it makes much more sense to me and gives more freedom to people on what they want to do, what do you think of it?))

comment:11 Changed 3 years ago by markedwards

@laurent:

I am adding a configuration file that lets the user choose to have autocomplete work for the username field and/or the password field, with the default being only the username field (good for security). When I've got that added, I will post the plugin in the repository and update this thread.

I personally agree that this makes sense as a standard config variable in main.inc.php, but Alec has spoken to that so whatever. This works, and Roundcube is awesome enough to make this easy to implement. The downside here is that this plugin will likely break with templates/skins other than the default, because it depends on the template's code.

comment:12 Changed 2 years ago by alec

  • Milestone changed from later to 0.5-stable
  • Resolution set to fixed
  • Status changed from reopened to closed

Added option login_autocomplete in [fbe24e9f] and [1cca4fbd].

Note: See TracTickets for help on using tickets.